Mirror/ardupilot
5
0
Fork 0
mirror of https://github.com/ArduPilot/ardupilot synced 2025-03-03 12:14:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

AP_RPM: removed create() method for objects

Browse Source 
See discussion here:

  https://github.com/ArduPilot/ardupilot/issues/7331

we were getting some uninitialised variables. While it only showed up in
AP_SbusOut, it means we can't be sure it won't happen on other objects,
so safest to remove the approach

Thanks to assistance from Lucas, Peter and Francisco
This commit is contained in:
Andrew Tridgell 2017-12-13 12:06:14 +11:00
parent 16cd31b63a
commit 9b4fef4d50
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/AP_RPM/AP_RPM.h
View File

@ -29,9 +29,7 @@ class AP_RPM
friend class AP_RPM_Backend; friend class AP_RPM_Backend;
public: public:
static AP_RPM create() { return AP_RPM{}; } AP_RPM();
constexpr AP_RPM(AP_RPM &&other) = default;
/* Do not allow copies */ /* Do not allow copies */
AP_RPM(const AP_RPM &other) = delete; AP_RPM(const AP_RPM &other) = delete;
@ -95,8 +93,6 @@ public:
bool enabled(uint8_t instance) const; bool enabled(uint8_t instance) const;
private: private:
AP_RPM();
RPM_State state[RPM_MAX_INSTANCES]; RPM_State state[RPM_MAX_INSTANCES];
AP_RPM_Backend *drivers[RPM_MAX_INSTANCES]; AP_RPM_Backend *drivers[RPM_MAX_INSTANCES];
uint8_t num_instances:2; uint8_t num_instances:2;

2
libraries/AP_RPM/examples/RPM_generic/RPM_generic.cpp
View File

@ -26,7 +26,7 @@ void loop();
const AP_HAL::HAL& hal = AP_HAL::get_HAL(); const AP_HAL::HAL& hal = AP_HAL::get_HAL();
static AP_RPM RPM = AP_RPM::create(); static AP_RPM RPM;
char sensor_state; char sensor_state;