Mirror/ardupilot
5
0
Fork 0
mirror of https://github.com/ArduPilot/ardupilot synced 2025-01-30 12:38:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

AP_InertialSensor: removed create() method for objects

Browse Source 
See discussion here:

  https://github.com/ArduPilot/ardupilot/issues/7331

we were getting some uninitialised variables. While it only showed up in
AP_SbusOut, it means we can't be sure it won't happen on other objects,
so safest to remove the approach

Thanks to assistance from Lucas, Peter and Francisco
This commit is contained in:
Andrew Tridgell 2017-12-13 12:06:12 +11:00
parent d2c9e2719e
commit 99499dece2
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/AP_InertialSensor/AP_InertialSensor.h
View File

@ -49,9 +49,7 @@ class AP_InertialSensor : AP_AccelCal_Client
friend class AP_InertialSensor_Backend; friend class AP_InertialSensor_Backend;
public: public:
static AP_InertialSensor create() { return AP_InertialSensor{}; } AP_InertialSensor();
constexpr AP_InertialSensor(AP_InertialSensor &&other) = default;
/* Do not allow copies */ /* Do not allow copies */
AP_InertialSensor(const AP_InertialSensor &other) = delete; AP_InertialSensor(const AP_InertialSensor &other) = delete;
@ -346,8 +344,6 @@ public:
BatchSampler batchsampler{*this}; BatchSampler batchsampler{*this};
private: private:
AP_InertialSensor();
// load backend drivers // load backend drivers
bool _add_backend(AP_InertialSensor_Backend *backend); bool _add_backend(AP_InertialSensor_Backend *backend);
void _start_backends(); void _start_backends();

4
libraries/AP_InertialSensor/examples/INS_generic/INS_generic.cpp
View File

@ -8,13 +8,13 @@
const AP_HAL::HAL &hal = AP_HAL::get_HAL(); const AP_HAL::HAL &hal = AP_HAL::get_HAL();
static AP_InertialSensor ins = AP_InertialSensor::create(); static AP_InertialSensor ins;
static void display_offsets_and_scaling(); static void display_offsets_and_scaling();
static void run_test(); static void run_test();
// board specific config // board specific config
static AP_BoardConfig BoardConfig = AP_BoardConfig::create(); static AP_BoardConfig BoardConfig;
void setup(void); void setup(void);
void loop(void); void loop(void);