mirror of
https://github.com/ArduPilot/ardupilot
synced 2025-02-22 07:44:03 -04:00
LogAnalyzer: Report missing parameters as test failures
This commit is contained in:
Kevin Hester
Randy Mackay
parent
332ab9bc1b
commit
5cb242f5a4
@ -15,96 +15,101 @@ class TestCompass(Test):
|
||||
self.result = TestResult()
|
||||
self.result.status = TestResult.StatusType.GOOD
|
||||
|
||||
# test that compass offset parameters are within recommended range (+/- 150)
|
||||
maxOffset = 150
|
||||
if logdata.hardwareType == "PX4":
|
||||
maxOffset = 250 # Pixhawks have their offsets scaled larger
|
||||
compassOfsX = logdata.parameters["COMPASS_OFS_X"]
|
||||
compassOfsY = logdata.parameters["COMPASS_OFS_Y"]
|
||||
compassOfsZ = logdata.parameters["COMPASS_OFS_Z"]
|
||||
if abs(compassOfsX) > maxOffset or abs(compassOfsY) > maxOffset or abs(compassOfsZ) > maxOffset:
|
||||
self.result.status = TestResult.StatusType.FAIL
|
||||
self.result.statusMessage = "Large compass off params (X:%.2f, Y:%.2f, Z:%.2f)\n" % (compassOfsX,compassOfsY,compassOfsZ)
|
||||
|
||||
# check for excessive compass offsets using MAG data if present (it can change during flight is compass learn is on)
|
||||
if "MAG" in logdata.channels:
|
||||
errMsg = ""
|
||||
if logdata.channels["MAG"]["OfsX"].max() > maxOffset:
|
||||
errMsg = errMsg + "\nX: %.2f" % logdata.channels["MAG"]["OfsX"].max()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsX"].min() < -maxOffset:
|
||||
errMsg = errMsg + "\nX: %.2f" % logdata.channels["MAG"]["OfsX"].min()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsY"].max() > maxOffset:
|
||||
errMsg = errMsg + "\nY: %.2f" % logdata.channels["MAG"]["OfsY"].max()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsY"].min() < -maxOffset:
|
||||
errMsg = errMsg + "\nY: %.2f" % logdata.channels["MAG"]["OfsY"].min()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsZ"].max() > maxOffset:
|
||||
errMsg = errMsg + "\nZ: %.2f" % logdata.channels["MAG"]["OfsZ"].max()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsZ"].min() < -maxOffset:
|
||||
errMsg = errMsg + "\nZ: %.2f" % logdata.channels["MAG"]["OfsZ"].min()
|
||||
err = True
|
||||
if errMsg:
|
||||
try:
|
||||
# test that compass offset parameters are within recommended range (+/- 150)
|
||||
maxOffset = 150
|
||||
if logdata.hardwareType == "PX4":
|
||||
maxOffset = 250 # Pixhawks have their offsets scaled larger
|
||||
compassOfsX = logdata.parameters["COMPASS_OFS_X"]
|
||||
compassOfsY = logdata.parameters["COMPASS_OFS_Y"]
|
||||
compassOfsZ = logdata.parameters["COMPASS_OFS_Z"]
|
||||
if abs(compassOfsX) > maxOffset or abs(compassOfsY) > maxOffset or abs(compassOfsZ) > maxOffset:
|
||||
self.result.status = TestResult.StatusType.FAIL
|
||||
self.result.statusMessage = self.result.statusMessage + "Large compass offset in MAG data:" + errMsg + "\n"
|
||||
self.result.statusMessage = "Large compass off params (X:%.2f, Y:%.2f, Z:%.2f)\n" % (compassOfsX,compassOfsY,compassOfsZ)
|
||||
|
||||
# check for mag field length change, and length outside of recommended range
|
||||
if "MAG" in logdata.channels:
|
||||
percentDiffThresholdWARN = 0.25
|
||||
percentDiffThresholdFAIL = 0.35
|
||||
minMagFieldThreshold = 120.0
|
||||
maxMagFieldThreshold = 550.0
|
||||
index = 0
|
||||
length = len(logdata.channels["MAG"]["MagX"].listData)
|
||||
magField = []
|
||||
(minMagField, maxMagField) = (None,None)
|
||||
(minMagFieldLine, maxMagFieldLine) = (None,None)
|
||||
zerosFound = False
|
||||
while index<length:
|
||||
mx = logdata.channels["MAG"]["MagX"].listData[index][1]
|
||||
my = logdata.channels["MAG"]["MagY"].listData[index][1]
|
||||
mz = logdata.channels["MAG"]["MagZ"].listData[index][1]
|
||||
if ((mx==0) and (my==0) and (mz==0)): # sometimes they're zero, not sure why, same reason as why we get NaNs as offsets?
|
||||
zerosFound = True
|
||||
# check for excessive compass offsets using MAG data if present (it can change during flight is compass learn is on)
|
||||
if "MAG" in logdata.channels:
|
||||
errMsg = ""
|
||||
if logdata.channels["MAG"]["OfsX"].max() > maxOffset:
|
||||
errMsg = errMsg + "\nX: %.2f" % logdata.channels["MAG"]["OfsX"].max()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsX"].min() < -maxOffset:
|
||||
errMsg = errMsg + "\nX: %.2f" % logdata.channels["MAG"]["OfsX"].min()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsY"].max() > maxOffset:
|
||||
errMsg = errMsg + "\nY: %.2f" % logdata.channels["MAG"]["OfsY"].max()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsY"].min() < -maxOffset:
|
||||
errMsg = errMsg + "\nY: %.2f" % logdata.channels["MAG"]["OfsY"].min()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsZ"].max() > maxOffset:
|
||||
errMsg = errMsg + "\nZ: %.2f" % logdata.channels["MAG"]["OfsZ"].max()
|
||||
err = True
|
||||
if logdata.channels["MAG"]["OfsZ"].min() < -maxOffset:
|
||||
errMsg = errMsg + "\nZ: %.2f" % logdata.channels["MAG"]["OfsZ"].min()
|
||||
err = True
|
||||
if errMsg:
|
||||
self.result.status = TestResult.StatusType.FAIL
|
||||
self.result.statusMessage = self.result.statusMessage + "Large compass offset in MAG data:" + errMsg + "\n"
|
||||
|
||||
# check for mag field length change, and length outside of recommended range
|
||||
if "MAG" in logdata.channels:
|
||||
percentDiffThresholdWARN = 0.25
|
||||
percentDiffThresholdFAIL = 0.35
|
||||
minMagFieldThreshold = 120.0
|
||||
maxMagFieldThreshold = 550.0
|
||||
index = 0
|
||||
length = len(logdata.channels["MAG"]["MagX"].listData)
|
||||
magField = []
|
||||
(minMagField, maxMagField) = (None,None)
|
||||
(minMagFieldLine, maxMagFieldLine) = (None,None)
|
||||
zerosFound = False
|
||||
while index<length:
|
||||
mx = logdata.channels["MAG"]["MagX"].listData[index][1]
|
||||
my = logdata.channels["MAG"]["MagY"].listData[index][1]
|
||||
mz = logdata.channels["MAG"]["MagZ"].listData[index][1]
|
||||
if ((mx==0) and (my==0) and (mz==0)): # sometimes they're zero, not sure why, same reason as why we get NaNs as offsets?
|
||||
zerosFound = True
|
||||
else:
|
||||
mf = math.sqrt(mx*mx + my*my + mz*mz)
|
||||
magField.append(mf)
|
||||
if mf<minMagField:
|
||||
minMagField = mf
|
||||
minMagFieldLine = logdata.channels["MAG"]["MagX"].listData[index][0]
|
||||
if mf>maxMagField:
|
||||
maxMagField = mf
|
||||
maxMagFieldLine = logdata.channels["MAG"]["MagX"].listData[index][0]
|
||||
if index == 0:
|
||||
(minMagField, maxMagField) = (mf,mf)
|
||||
index += 1
|
||||
percentDiff = (maxMagField-minMagField) / minMagField
|
||||
if percentDiff > percentDiffThresholdFAIL:
|
||||
self.result.status = TestResult.StatusType.FAIL
|
||||
self.result.statusMessage = self.result.statusMessage + "Large change in mag_field (%.2f%%)\n" % (percentDiff*100)
|
||||
elif percentDiff > percentDiffThresholdWARN:
|
||||
if self.result.status != TestResult.StatusType.FAIL:
|
||||
self.result.status = TestResult.StatusType.WARN
|
||||
self.result.statusMessage = self.result.statusMessage + "Moderate change in mag_field (%.2f%%)\n" % (percentDiff*100)
|
||||
else:
|
||||
mf = math.sqrt(mx*mx + my*my + mz*mz)
|
||||
magField.append(mf)
|
||||
if mf<minMagField:
|
||||
minMagField = mf
|
||||
minMagFieldLine = logdata.channels["MAG"]["MagX"].listData[index][0]
|
||||
if mf>maxMagField:
|
||||
maxMagField = mf
|
||||
maxMagFieldLine = logdata.channels["MAG"]["MagX"].listData[index][0]
|
||||
if index == 0:
|
||||
(minMagField, maxMagField) = (mf,mf)
|
||||
index += 1
|
||||
percentDiff = (maxMagField-minMagField) / minMagField
|
||||
if percentDiff > percentDiffThresholdFAIL:
|
||||
self.result.status = TestResult.StatusType.FAIL
|
||||
self.result.statusMessage = self.result.statusMessage + "Large change in mag_field (%.2f%%)\n" % (percentDiff*100)
|
||||
elif percentDiff > percentDiffThresholdWARN:
|
||||
if self.result.status != TestResult.StatusType.FAIL:
|
||||
self.result.status = TestResult.StatusType.WARN
|
||||
self.result.statusMessage = self.result.statusMessage + "Moderate change in mag_field (%.2f%%)\n" % (percentDiff*100)
|
||||
self.result.statusMessage = self.result.statusMessage + "mag_field interference within limits (%.2f%%)\n" % (percentDiff*100)
|
||||
if minMagField < minMagFieldThreshold:
|
||||
self.result.statusMessage = self.result.statusMessage + "Min mag field length (%.2f) < recommended (%.2f)\n" % (minMagField,minMagFieldThreshold)
|
||||
if maxMagField > maxMagFieldThreshold:
|
||||
self.result.statusMessage = self.result.statusMessage + "Max mag field length (%.2f) > recommended (%.2f)\n" % (maxMagField,maxMagFieldThreshold)
|
||||
if zerosFound:
|
||||
if self.result.status != TestResult.StatusType.FAIL:
|
||||
self.result.status = TestResult.StatusType.WARN
|
||||
self.result.statusMessage = self.result.statusMessage + "All zeros found in MAG X/Y/Z log data\n"
|
||||
if verbose:
|
||||
self.result.statusMessage = self.result.statusMessage + "Min mag_field of %.2f on line %d\n" % (minMagField,minMagFieldLine)
|
||||
self.result.statusMessage = self.result.statusMessage + "Max mag_field of %.2f on line %d\n" % (maxMagField,maxMagFieldLine)
|
||||
|
||||
else:
|
||||
self.result.statusMessage = self.result.statusMessage + "mag_field interference within limits (%.2f%%)\n" % (percentDiff*100)
|
||||
if minMagField < minMagFieldThreshold:
|
||||
self.result.statusMessage = self.result.statusMessage + "Min mag field length (%.2f) < recommended (%.2f)\n" % (minMagField,minMagFieldThreshold)
|
||||
if maxMagField > maxMagFieldThreshold:
|
||||
self.result.statusMessage = self.result.statusMessage + "Max mag field length (%.2f) > recommended (%.2f)\n" % (maxMagField,maxMagFieldThreshold)
|
||||
if zerosFound:
|
||||
if self.result.status != TestResult.StatusType.FAIL:
|
||||
self.result.status = TestResult.StatusType.WARN
|
||||
self.result.statusMessage = self.result.statusMessage + "All zeros found in MAG X/Y/Z log data\n"
|
||||
if verbose:
|
||||
self.result.statusMessage = self.result.statusMessage + "Min mag_field of %.2f on line %d\n" % (minMagField,minMagFieldLine)
|
||||
self.result.statusMessage = self.result.statusMessage + "Max mag_field of %.2f on line %d\n" % (maxMagField,maxMagFieldLine)
|
||||
self.result.statusMessage = self.result.statusMessage + "No MAG data, unable to test mag_field interference\n"
|
||||
|
||||
else:
|
||||
self.result.statusMessage = self.result.statusMessage + "No MAG data, unable to test mag_field interference\n"
|
||||
except KeyError as e:
|
||||
self.result.status = TestResult.StatusType.FAIL
|
||||
self.result.statusMessage = str(e) + ' not found'
|
||||
|
||||
|
||||
|
||||
|
||||
@ -40,20 +40,24 @@ class TestParams(Test):
|
||||
self.result.status = TestResult.StatusType.FAIL
|
||||
self.result.statusMessage = self.result.statusMessage + name + " is NaN\n"
|
||||
|
||||
# add parameter checks below using the helper functions, any failures will trigger a FAIL status and accumulate info in statusMessage
|
||||
# if more complex checking or correlations are required you can access parameter values directly using the logdata.parameters[paramName] dict
|
||||
if logdata.vehicleType == "ArduCopter":
|
||||
self.__checkParamIsEqual ("MAG_ENABLE", 1, logdata)
|
||||
self.__checkParamIsLessThan("THR_MIN", 200, logdata)
|
||||
self.__checkParamIsLessThan("THR_MID", 701, logdata)
|
||||
self.__checkParamIsMoreThan("THR_MID", 299, logdata)
|
||||
# TODO: add more parameter tests, these are just an example...
|
||||
elif logdata.vehicleType == "ArduPlane":
|
||||
# TODO: add parameter checks for plane...
|
||||
pass
|
||||
elif logdata.vehicleType == "ArduRover":
|
||||
# TODO: add parameter checks for rover...
|
||||
pass
|
||||
try:
|
||||
# add parameter checks below using the helper functions, any failures will trigger a FAIL status and accumulate info in statusMessage
|
||||
# if more complex checking or correlations are required you can access parameter values directly using the logdata.parameters[paramName] dict
|
||||
if logdata.vehicleType == "ArduCopter":
|
||||
self.__checkParamIsEqual ("MAG_ENABLE", 1, logdata)
|
||||
self.__checkParamIsLessThan("THR_MIN", 200, logdata)
|
||||
self.__checkParamIsLessThan("THR_MID", 701, logdata)
|
||||
self.__checkParamIsMoreThan("THR_MID", 299, logdata)
|
||||
# TODO: add more parameter tests, these are just an example...
|
||||
elif logdata.vehicleType == "ArduPlane":
|
||||
# TODO: add parameter checks for plane...
|
||||
pass
|
||||
elif logdata.vehicleType == "ArduRover":
|
||||
# TODO: add parameter checks for rover...
|
||||
pass
|
||||
|
||||
if self.result.status == TestResult.StatusType.FAIL:
|
||||
self.result.statusMessage = "Bad parameters found:\n" + self.result.statusMessage
|
||||
if self.result.status == TestResult.StatusType.FAIL:
|
||||
self.result.statusMessage = "Bad parameters found:\n" + self.result.statusMessage
|
||||
except KeyError as e:
|
||||
self.result.status = TestResult.StatusType.FAIL
|
||||
self.result.statusMessage = str(e) + ' not found'
|
||||
Loading…
Reference in New Issue
Block a user