AP_AccelCal: limit COMMAND_ACKs accepted for vehicle pose confirmation

libraries/AP_AccelCal/AP_AccelCal.cpp

@@ -367,6 +367,26 @@ void AP_AccelCal::handle_command_ack(const mavlink_command_ack_t &packet)
     if (!_waiting_for_mavlink_ack) {
         return;
     }
+    // this is support for the old, non-accelcal-specific calibration.
+    // The GCS is expected to send back a COMMAND_ACK when the vehicle
+    // is posed, but we placed no constraints on the result code or
+    // the command field in the ack packet.  That meant that any ACK
+    // would move the cal process forward - and since we don't even
+    // check the source system/component here the process could easily
+    // fail due to other ACKs floating around the mavlink network.
+    // GCSs should be moved to using the non-gcs-snoop method.  As a
+    // round-up:
+    // MAVProxy: command=1-6 depending on pose, result=1
+    // QGC: command=0, result=1
+    // MissionPlanner: uses new ACCELCAL_VEHICLE_POS
+    if (packet.command > 6) {
+        // not an acknowledgement for a vehicle position
+        return;
+    }
+    if (packet.result != MAV_RESULT_TEMPORARILY_REJECTED) {
+        // not an acknowledgement for a vehicle position
+        return;
+    }
     _waiting_for_mavlink_ack = false;
     _start_collect_sample = true;
 }