Mirror/ardupilot
5
0
Fork 0
mirror of https://github.com/ArduPilot/ardupilot synced 2025-01-05 07:28:29 -04:00
Code Issues Packages Projects Releases Wiki Activity

GCS_MAVLink: zero signing key structure for valgrind

Browse Source 
the signing key structure is not marked as packed, which means it has
a 4 byte padding between the uint32_t magic and the uint64_t
timestamp. This gets written to the database and valgrind warns about
a write of uninitialised bytes. It is harmless as when the structure
is read the field is not used
This commit is contained in:
Andrew Tridgell 2024-09-07 13:12:36 +10:00 committed by Peter Barker
parent 7280ff3ffd
commit 3dd44dd8e0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/GCS_MAVLink/GCS_Signing.cpp
View File

@ -80,7 +80,7 @@ void GCS_MAVLINK::handle_setup_signing(const mavlink_message_t &msg) const
mavlink_setup_signing_t packet; mavlink_setup_signing_t packet;
mavlink_msg_setup_signing_decode(&msg, &packet); mavlink_msg_setup_signing_decode(&msg, &packet);
struct SigningKey key; struct SigningKey key {};
key.magic = SIGNING_KEY_MAGIC; key.magic = SIGNING_KEY_MAGIC;
key.timestamp = packet.initial_timestamp; key.timestamp = packet.initial_timestamp;
memcpy(key.secret_key, packet.secret_key, 32); memcpy(key.secret_key, packet.secret_key, 32);