Mirror/ardupilot
5
0
Fork 0
mirror of https://github.com/ArduPilot/ardupilot synced 2025-02-01 21:48:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

Filter: validity of array index was checked AFTER accessing the element.

Browse Source 
(correction decreased Program size by 12 bytes)
This commit is contained in:
Tobias 2013-05-17 16:38:20 +02:00 committed by Andrew Tridgell
parent d3ea88e8c7
commit 338c054da2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/Filter/ModeFilter.h
View File

@ -111,7 +111,7 @@ void ModeFilter<T,FILTER_SIZE>:: isort(T new_sample, bool drop_high)
i = FilterWithBuffer<T,FILTER_SIZE>::sample_index-1; i = FilterWithBuffer<T,FILTER_SIZE>::sample_index-1;
// if the next element is higher than our new sample, push it up one position // if the next element is higher than our new sample, push it up one position
while( FilterWithBuffer<T,FILTER_SIZE>::samples[i-1] > new_sample && i > 0 ) { while(i > 0 && FilterWithBuffer<T,FILTER_SIZE>::samples[i-1] > new_sample) {
FilterWithBuffer<T,FILTER_SIZE>::samples[i] = FilterWithBuffer<T,FILTER_SIZE>::samples[i-1]; FilterWithBuffer<T,FILTER_SIZE>::samples[i] = FilterWithBuffer<T,FILTER_SIZE>::samples[i-1];
i--; i--;
} }