From 138464cab8ed924fedfbfe0b42e738655146dc67 Mon Sep 17 00:00:00 2001
From: bugobliterator <siddharthbharatpurohit@gmail.com>
Date: Wed, 12 Apr 2023 17:35:08 +1000
Subject: [PATCH] AP_Scripting: remove example/mavlink.lua and fix lua test

---
 libraries/AP_Scripting/examples/mavlink.lua   | 37 -------------------
 libraries/AP_Scripting/tests/mavlink_test.lua | 14 +++----
 2 files changed, 7 insertions(+), 44 deletions(-)
 delete mode 100644 libraries/AP_Scripting/examples/mavlink.lua

diff --git a/libraries/AP_Scripting/examples/mavlink.lua b/libraries/AP_Scripting/examples/mavlink.lua
deleted file mode 100644
index 0f0b6dafca..0000000000
--- a/libraries/AP_Scripting/examples/mavlink.lua
+++ /dev/null
@@ -1,37 +0,0 @@
-mavlink_msgs = require("mavlink_msgs")
-
-msg_map = {}
-
-heartbeat_msgid = mavlink_msgs.get_msgid("HEARTBEAT")
-
-msg_map[heartbeat_msgid] = "HEARTBEAT"
--- initialise mavlink rx with number of messages, and buffer depth
-mavlink.init(1, 10)
--- register message id to receive
-mavlink.receive_msgid(heartbeat_msgid)
-test_named_value = 0.0
-function str_to_bytes(str)
-    str_len = string.len(str)
-    bytes =  {}
-    for i = 1, str_len do
-        bytes[i] = string.byte(str, i)
-    end
-    return bytes
-end
-function update()
-    local msg = mavlink.receive()
-    if msg then
-        parsed_msg = mavlink_msgs.decode(msg, msg_map)
-        if parsed_msg.msgid == heartbeat_msgid then
-            gcs:send_text(6, string.format("Received heartbeat from %d", parsed_msg.sysid))
-        end
-    else
-        gcs:send_text(6, "No heartbeat received")
-    end
-    test_named_value = test_named_value + 1.0
-    -- send named value float to channel 0
-    mavlink.send(0, mavlink_msgs.encode("NAMED_VALUE_FLOAT", {time_boot_ms = millis():toint(), name = str_to_bytes("test"), value = test_named_value}))
-    return update, 1000
-end
-
-return update()
diff --git a/libraries/AP_Scripting/tests/mavlink_test.lua b/libraries/AP_Scripting/tests/mavlink_test.lua
index e9abebe2d0..59488524c6 100644
--- a/libraries/AP_Scripting/tests/mavlink_test.lua
+++ b/libraries/AP_Scripting/tests/mavlink_test.lua
@@ -1,18 +1,18 @@
-mavlink_msgs = require("mavlink/mavlink_msgs")
+local mavlink_msgs = require("mavlink/mavlink_msgs")
 
-msg_map = {}
+local msg_map = {}
 
-heartbeat_msgid = mavlink_msgs.get_msgid("HEARTBEAT")
+local heartbeat_msgid = mavlink_msgs.get_msgid("HEARTBEAT")
 
 msg_map[heartbeat_msgid] = "HEARTBEAT"
 -- initialise mavlink rx with number of messages, and buffer depth
 mavlink.init(1, 10)
 -- register message id to receive
 mavlink.receive_msgid(heartbeat_msgid)
-test_named_value = 0.0
+local test_named_value = 0.0
 function str_to_bytes(str)
-    str_len = string.len(str)
-    bytes =  {}
+    local str_len = string.len(str)
+    local bytes =  {}
     for i = 1, str_len do
         bytes[i] = string.byte(str, i)
     end
@@ -21,7 +21,7 @@ end
 function update()
     local msg = mavlink.receive()
     if msg then
-        parsed_msg = mavlink_msgs.decode(msg, msg_map)
+        local parsed_msg = mavlink_msgs.decode(msg, msg_map)
         if parsed_msg.msgid == heartbeat_msgid then
             gcs:send_text(6, string.format("Received heartbeat from %d", parsed_msg.sysid))
         end