Mirror
/
ardupilot
mirror of https://github.com/ArduPilot/ardupilot
5
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

AP_DroneCAN: DNAServer: optimize allocation strategy 

Number of allocation messages with 3 nodes (6 trials):

before: 44, 36, 35, 92, 107, 41

after: 28, 28, 28, 28, 26, 28
This commit is contained in:
Thomas Watson 2024-09-09 22:44:17 -05:00 committed by Andrew Tridgell
parent dcfbf0ab69
commit 12a106333c
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
libraries/AP_DroneCAN/AP_DroneCAN_DNA_Server.cpp
View File

@ -450,15 +450,18 @@ void AP_DroneCAN_DNA_Server::handle_allocation(const CanardRxTransfer& transfer,
}
uint32_t now = AP_HAL::millis();
if (rcvd_unique_id_offset == 0 ||
(now - last_alloc_msg_ms) > UAVCAN_PROTOCOL_DYNAMIC_NODE_ID_ALLOCATION_FOLLOWUP_TIMEOUT_MS) {
if (msg.first_part_of_unique_id) {
rcvd_unique_id_offset = 0;
} else {
return; // only accepting the first part
}
} else if (msg.first_part_of_unique_id) {
return; // only accepting follow up messages
if ((now - last_alloc_msg_ms) > UAVCAN_PROTOCOL_DYNAMIC_NODE_ID_ALLOCATION_FOLLOWUP_TIMEOUT_MS) {
rcvd_unique_id_offset = 0; // reset state, timed out
}
if (msg.first_part_of_unique_id) {
// nodes waiting to send a follow up will instead send a first part
// again if they see another allocation message. therefore we should
// always reset and process a received first part, since any node we
// were allocating will never send its follow up and we'd just time out
rcvd_unique_id_offset = 0;
} else if (rcvd_unique_id_offset == 0) {
return; // not first part but we are expecting one, ignore
}
if (rcvd_unique_id_offset) {