diff --git a/libraries/AP_Common/Bitmask.h b/libraries/AP_Common/Bitmask.h index 4662a2a219..ed4443d294 100644 --- a/libraries/AP_Common/Bitmask.h +++ b/libraries/AP_Common/Bitmask.h @@ -23,28 +23,28 @@ #include -template +template class Bitmask { - static_assert(num_bits > 0, "must store something"); + static constexpr uint16_t NUMWORDS = ((NUMBITS+31)/32); + + static_assert(NUMBITS > 0, "must store something"); // for first_set()'s return value - static_assert(num_bits <= INT16_MAX, "must fit in int16_t"); + static_assert(NUMBITS <= INT16_MAX, "must fit in int16_t"); // so that 1U << bits is in range static_assert(sizeof(unsigned int) >= sizeof(uint32_t), "int too small"); public: - Bitmask() : - numbits(num_bits), - numwords((num_bits+31)/32) { + Bitmask() { clearall(); } Bitmask &operator=(const Bitmask&other) { - memcpy(bits, other.bits, sizeof(bits[0])*numwords); + memcpy(bits, other.bits, sizeof(bits[0])*NUMWORDS); return *this; } bool operator==(const Bitmask&other) { - return memcmp(bits, other.bits, sizeof(bits[0])*numwords) == 0; + return memcmp(bits, other.bits, sizeof(bits[0])*NUMWORDS) == 0; } bool operator!=(const Bitmask&other) { @@ -66,13 +66,13 @@ public: // set all bits void setall(void) { // set all words to 111... - for (uint16_t i=0; i= numbits) { + if (bit >= NUMBITS) { INTERNAL_ERROR(AP_InternalError::error_t::bitmask_range); return false; } return true; } - uint16_t numbits; - uint16_t numwords; - uint32_t bits[(num_bits+31)/32]; + uint32_t bits[NUMWORDS]; };