#!/usr/bin/env python3 # -*- coding: utf-8 -*- # Check for stylistic and formal issues in .rst and .py # files included in the documentation. # # 01/2009, Georg Brandl # TODO: - wrong versions in versionadded/changed # - wrong markup after versionchanged directive import os import re import sys import getopt from string import ascii_letters from os.path import join, splitext, abspath, exists from collections import defaultdict directives = [ # standard docutils ones 'admonition', 'attention', 'caution', 'class', 'compound', 'container', 'contents', 'csv-table', 'danger', 'date', 'default-role', 'epigraph', 'error', 'figure', 'footer', 'header', 'highlights', 'hint', 'image', 'important', 'include', 'line-block', 'list-table', 'meta', 'note', 'parsed-literal', 'pull-quote', 'raw', 'replace', 'restructuredtext-test-directive', 'role', 'rubric', 'sectnum', 'sidebar', 'table', 'target-notes', 'tip', 'title', 'topic', 'unicode', 'warning', # Sphinx and Python docs custom ones 'acks', 'attribute', 'autoattribute', 'autoclass', 'autodata', 'autoexception', 'autofunction', 'automethod', 'automodule', 'availability', 'centered', 'cfunction', 'class', 'classmethod', 'cmacro', 'cmdoption', 'cmember', 'code-block', 'confval', 'cssclass', 'ctype', 'currentmodule', 'cvar', 'data', 'decorator', 'decoratormethod', 'deprecated-removed', 'deprecated(?!-removed)', 'describe', 'directive', 'doctest', 'envvar', 'event', 'exception', 'function', 'glossary', 'highlight', 'highlightlang', 'impl-detail', 'index', 'literalinclude', 'method', 'miscnews', 'module', 'moduleauthor', 'opcode', 'pdbcommand', 'productionlist', 'program', 'role', 'sectionauthor', 'seealso', 'sourcecode', 'staticmethod', 'tabularcolumns', 'testcode', 'testoutput', 'testsetup', 'toctree', 'todo', 'todolist', 'versionadded', 'versionchanged' ] all_directives = '(' + '|'.join(directives) + ')' seems_directive_re = re.compile(r'(? 81: # don't complain about tables, links and function signatures if line.lstrip()[0] not in '+|' and \ 'http://' not in line and \ not line.lstrip().startswith(('.. function', '.. method', '.. cfunction')): yield lno+1, "line too long" @checker('.html', severity=2, falsepositives=True) def check_leaked_markup(fn, lines): """Check HTML files for leaked reST markup; this only works if the HTML files have been built. """ for lno, line in enumerate(lines): if leaked_markup_re.search(line): yield lno+1, 'possibly leaked markup: %r' % line def hide_literal_blocks(lines): """Tool to remove literal blocks from given lines. It yields empty lines in place of blocks, so line numbers are still meaningful. """ in_block = False for line in lines: if line.endswith("::\n"): in_block = True elif in_block: if line == "\n" or line.startswith(" "): line = "\n" else: in_block = False yield line def type_of_explicit_markup(line): if re.match(fr'\.\. {all_directives}::', line): return 'directive' if re.match(r'\.\. \[[0-9]+\] ', line): return 'footnote' if re.match(r'\.\. \[[^\]]+\] ', line): return 'citation' if re.match(r'\.\. _.*[^_]: ', line): return 'target' if re.match(r'\.\. \|[^\|]*\| ', line): return 'substitution_definition' return 'comment' def hide_comments(lines): """Tool to remove comments from given lines. It yields empty lines in place of comments, so line numbers are still meaningfull. """ in_multiline_comment = False for line in lines: if line == "..\n": in_multiline_comment = True elif in_multiline_comment: if line == "\n" or line.startswith(" "): line = "\n" else: in_multiline_comment = False if line.startswith(".. ") and type_of_explicit_markup(line) == 'comment': line = "\n" yield line @checker(".rst", severity=2) def check_missing_surrogate_space_on_plural(fn, lines): r"""Check for missing 'backslash-space' between a code sample a letter. Good: ``Point``\ s Bad: ``Point``s """ in_code_sample = False check_next_one = False for lno, line in enumerate(hide_comments(hide_literal_blocks(lines))): tokens = line.split("``") for token_no, token in enumerate(tokens): if check_next_one: if token[0] in ascii_letters: yield lno + 1, f"Missing backslash-space between code sample and {token!r}." check_next_one = False if token_no == len(tokens) - 1: continue if in_code_sample: check_next_one = True in_code_sample = not in_code_sample def main(argv): usage = '''\ Usage: %s [-v] [-f] [-s sev] [-i path]* [path] Options: -v verbose (print all checked file names) -f enable checkers that yield many false positives -s sev only show problems with severity >= sev -i path ignore subdir or file path ''' % argv[0] try: gopts, args = getopt.getopt(argv[1:], 'vfs:i:') except getopt.GetoptError: print(usage) return 2 verbose = False severity = 1 ignore = [] falsepos = False for opt, val in gopts: if opt == '-v': verbose = True elif opt == '-f': falsepos = True elif opt == '-s': severity = int(val) elif opt == '-i': ignore.append(abspath(val)) if len(args) == 0: path = '.' elif len(args) == 1: path = args[0] else: print(usage) return 2 if not exists(path): print('Error: path %s does not exist' % path) return 2 count = defaultdict(int) for root, dirs, files in os.walk(path): # ignore subdirs in ignore list if abspath(root) in ignore: del dirs[:] continue for fn in files: fn = join(root, fn) if fn[:2] == './': fn = fn[2:] # ignore files in ignore list if abspath(fn) in ignore: continue ext = splitext(fn)[1] checkerlist = checkers.get(ext, None) if not checkerlist: continue if verbose: print('Checking %s...' % fn) try: with open(fn, 'r', encoding='utf-8') as f: lines = list(f) except (IOError, OSError) as err: print('%s: cannot open: %s' % (fn, err)) count[4] += 1 continue for checker in checkerlist: if checker.falsepositives and not falsepos: continue csev = checker.severity if csev >= severity: for lno, msg in checker(fn, lines): print('[%d] %s:%d: %s' % (csev, fn, lno, msg)) count[csev] += 1 if verbose: print() if not count: if severity > 1: print('No problems with severity >= %d found.' % severity) else: print('No problems found.') else: for severity in sorted(count): number = count[severity] print('%d problem%s with severity %d found.' % (number, number > 1 and 's' or '', severity)) return int(bool(count)) if __name__ == '__main__': sys.exit(main(sys.argv))