b3153832c2
Clean up _bsddb.c: add a couple dozen missing Py_DECREF()'s, a handful of
...
missing PyObject_Del()'s, simplify some code by using Py_BuildValue()
instead of creating a tuple with items manually, stop clobbering builtin
exceptions in a few places, and guard against NULL-returning functions some
more.
This fixes 117 of the 780 (!?!#%@#$!!) reference leaks in test_bsddb3. I
ain't not done yet, although this review of 5kloc was just the easy part.
2006-03-08 01:47:19 +00:00
e920f0d340
Reformulate 42903 using an if statement.
2006-03-07 23:59:33 +00:00
df44ab7b1c
_hotshot hotshot_profiler(): If write_header() returned
...
an error code, this let `self` leak. This is a disaster
on Windows, since `self` already points to a newly-opened
file object, and it was impossible for Python code to
close the thing since the only reference to it was in a
blob of leaked C memory.
test_hotshot test_bad_sys_path(): This new test provoked
the C bug above. This test passed, but left an open
"@test" file behind, which caused a massive cascade of
bogus test failures in later, unrelated tests on Windows.
Changed the test code to remove the @test file it leaves
behind, which relies on the change above to close that
file first.
2006-03-07 23:53:32 +00:00
516999e6e2
Fix bug introduced in rev. 42884.
2006-03-07 20:56:02 +00:00
437567ca7b
Some edits; add empty sections
2006-03-07 20:48:55 +00:00
9aa37ab5d2
Add note about PEP 357.
2006-03-07 18:54:08 +00:00
38fff8c4e4
Checking in the code for PEP 357.
...
This was mostly written by Travis Oliphant.
I've inspected it all; Neal Norwitz and MvL have also looked at it
(in an earlier incarnation).
2006-03-07 18:50:55 +00:00
9d7855076a
Address an coverity issue. Coverity was complaining about a line that's fine,
...
but an earlier line checked for v != NULL unnecessarily.
2006-03-07 18:31:44 +00:00
ec73cd4b1a
Typo fix
2006-03-07 16:16:07 +00:00
4af5c8cee4
SF #1444030 : Fix several potential defects found by Coverity.
...
(reviewed by Neal Norwitz)
2006-03-07 15:39:21 +00:00
ef1701f7d3
Add additional missing checks for return vals of PyTuple_New().
...
Normalize coding style.
2006-03-07 14:57:48 +00:00
89ba38152d
Fix gcc 4.0.x warning about use of uninitialized value.
2006-03-07 14:14:51 +00:00
098f6943c0
Coverity found bug: test result of PyTuple_New() against NULL before use.
...
Will backport.
2006-03-07 14:13:17 +00:00
a74a84d4cb
Coverity found refleak: need to free 'v' after calling Tkinter_Error().
...
Will backport to release24.
2006-03-07 14:04:31 +00:00
58780d2642
Bug #1440831 : fix csv UnicodeWriter example
2006-03-07 13:47:22 +00:00
47f003d326
Coverity-found bug: don't use temp->next *before* checking it for NULL. Also
...
return rather than use it again.
2006-03-07 13:38:14 +00:00
622927b850
Bug #1432525 : os.listdir now releases the GIL while calling
...
readdir().
2006-03-07 12:48:03 +00:00
725507b52e
Change int to Py_ssize_t in several places.
...
Add (int) casts to silence compiler warnings.
Raise Python exceptions for overflows.
2006-03-07 12:08:51 +00:00
8eb8a829c1
Don't DECREF a borrowed reference.
2006-03-07 11:58:50 +00:00
d3c38ff7f8
SF patch #1443865 ; gc.get_count() added and optional argument 'generation'
...
added to gc.collect(). Updated docs, unit test, and NEWS entry.
(Also, fixed a typo in NEWS.)
2006-03-07 09:46:03 +00:00
995acdf308
Add a note about the bug fixes
2006-03-07 05:01:00 +00:00
60da31660c
Thanks to Coverity, these were all reported by their Prevent tool.
...
All of these (except _lsprof.c) should be backported. Particularly
the hotshot change which validates sys.path. Can someone backport?
2006-03-07 04:48:24 +00:00
e22373d690
Fix warnings on x86 (32-bit) and support Win64.
2006-03-06 23:31:56 +00:00
f2e0c45492
Fix warnings on x86 (32-bit).
2006-03-06 23:31:27 +00:00
3e90fa5940
Try to cleanup the error handling a bit so there aren't false positives
...
from static analysis. v was already checked for NULL above, so we don't
need a second check.
2006-03-06 23:07:34 +00:00
4dc4a8401a
Ignore leaks from the socket test too. Sigh, this list is getting long. :-(
2006-03-06 23:04:04 +00:00
ca199432c2
If size is specified, try to read at least size characters.
...
This is a alternative version of patch #1379332 .
2006-03-06 22:39:12 +00:00
f8d767198f
lower-case time_t.
2006-03-06 16:32:05 +00:00
a2d4d6c285
Patch #1437769 : notice that time_t is a 64-bit type in VS2005
2006-03-06 16:30:25 +00:00
32feb8592f
Check NULL if Py_InitModule fails.
2006-03-06 07:51:19 +00:00
82f6cc4728
Use devenv.com to better obtain output.
2006-03-05 16:47:11 +00:00
350a872e59
Add buildbot support scripts.
2006-03-05 16:18:44 +00:00
8c7c56e7c3
Add _msi.pyd.
...
Add warning on Win9x.
2006-03-05 14:04:26 +00:00
d149c21d54
Open dll file in binary.
2006-03-05 13:52:20 +00:00
dd860caa8f
Update copyright notice.
2006-03-05 13:39:10 +00:00
fbab90e95b
Import bdist_msi
2006-03-05 13:36:04 +00:00
99b93c2824
Use %Id for size_t-ish things on Win64.
2006-03-05 05:33:54 +00:00
5bab0f8872
Backout the last hack and add in this new one.
...
The failure definitely seems timing related. This change *seems* to work.
Since the failure isn't doesn't occur consistently, it's hard to tell.
Running these tests on Solaris in this order:
test_urllibnet test_operator test_cgi \
test_isinstance test_future test_ast test_logging
generally caused a failure (about 50% of the time) before the sleep.
I couldn't provoke the failure with the sleep.
This should really be cleaned up by using threading.Events or something
so it is not timing dependent and doesn't hang forever on failure.
2006-03-05 02:16:12 +00:00
83cbb24cd4
Oops, urllib may or may not already be loaded.
2006-03-04 23:56:53 +00:00
0917988f7c
Fix SF #1442937 , Bad Coroutine link
2006-03-04 23:31:45 +00:00
d8cea79bb4
Fix spurious test failure of test_socket_ssl when run in this order:
...
test_codecmaps_tw test_importhooks test_socket_ssl
I don't completely understand the cause, but there's a lot of import magic
going on and this is the smallest change which fixes the problem.
2006-03-04 23:13:41 +00:00
7b216c52e4
Make PyGC_Collect() use Py_ssize_t.
2006-03-04 20:01:53 +00:00
84632ee319
Oops, forgot to include this in the last checkin.
...
Actually define Py_RefTotal as a Py_ssize_t.
2006-03-04 20:00:59 +00:00
4281cef205
Use Py_ssize_t for _Py_RefTotal.
...
I tried to handle Win64 properly, but please review.
2006-03-04 19:58:13 +00:00
9589ee276a
Tabify
2006-03-04 19:01:22 +00:00
e92fba0a12
Get rid of run_err_mod(). It was only used in two places.
...
One place it wasn't necessary since mod was already checked.
Inline the check that mod != NULL for the other use.
2006-03-04 18:52:26 +00:00
1fc4b776d4
Change some sequnce APIs to use Py_ssize_t.
2006-03-04 18:49:58 +00:00
8c49c82889
Use Py_ssize_t for PySet_Size() like all the other Py*_Size() functions.
2006-03-04 18:41:19 +00:00
b62c433d71
Remove test for timing (already not built since commented out in setup.py).
...
Add note to NEWS.
2006-03-04 18:35:47 +00:00
4b96c1384e
- Modernize code to use Py_ssize_t more intensively.
...
- Do some minor code clean-ups.
2006-03-04 16:08:19 +00:00
Thomas Wouters
Martin v. Löwis
Tim Peters
Georg Brandl
Andrew M. Kuchling
Guido van Rossum
Hye-Shik Chang
Barry Warsaw
Neal Norwitz
Walter Dörwald