From fc2d01032fa4eb2d5563c2619811d05567faf528 Mon Sep 17 00:00:00 2001 From: Facundo Batista Date: Sat, 23 Feb 2008 12:01:13 +0000 Subject: [PATCH] Issue 1881. Increased the stack limit from 500 to 1500. Also added a test for this (and because of this test you'll see in stderr a message that parser.c sends before raising MemoryError). Thanks Ralf Schmitt. --- Lib/test/test_parser.py | 17 +++++++++++++++++ Misc/NEWS | 3 +++ Parser/parser.h | 2 +- 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/Lib/test/test_parser.py b/Lib/test/test_parser.py index fd2861034d6..411911211a3 100644 --- a/Lib/test/test_parser.py +++ b/Lib/test/test_parser.py @@ -480,11 +480,28 @@ class CompileTestCase(unittest.TestCase): st = parser.suite('a = u"\u1"') self.assertRaises(SyntaxError, parser.compilest, st) +class ParserStackLimitTestCase(unittest.TestCase): + """try to push the parser to/over it's limits. + see http://bugs.python.org/issue1881 for a discussion + """ + def _nested_expression(self, level): + return "["*level+"]"*level + + def test_deeply_nested_list(self): + e = self._nested_expression(99) + st = parser.expr(e) + st.compile() + + def test_trigger_memory_error(self): + e = self._nested_expression(100) + self.assertRaises(MemoryError, parser.expr, e) + def test_main(): test_support.run_unittest( RoundtripLegalSyntaxTestCase, IllegalSyntaxTestCase, CompileTestCase, + ParserStackLimitTestCase, ) diff --git a/Misc/NEWS b/Misc/NEWS index 2921cb2af95..a33bf714c45 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -12,6 +12,9 @@ What's New in Python 2.6 alpha 1? Core and builtins ----------------- +- Issue #1881: An internal parser limit has been increased. Also see + issue 215555 for a discussion. + - Added the future_builtins module, which contains hex() and oct(). These are the PEP 3127 version of these functions, designed to be compatible with the hex() and oct() builtins from Python 3.0. They diff --git a/Parser/parser.h b/Parser/parser.h index bdca3e9440a..403236d1ea2 100644 --- a/Parser/parser.h +++ b/Parser/parser.h @@ -7,7 +7,7 @@ extern "C" { /* Parser interface */ -#define MAXSTACK 500 +#define MAXSTACK 1500 typedef struct { int s_state; /* State in current DFA */