From f192aeb95a139ede74d69e39c046c498ff288a37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Srinivas=20=20Thatiparthy=20=28=E0=B0=B6=E0=B1=8D=E0=B0=B0?= =?UTF-8?q?=E0=B1=80=E0=B0=A8=E0=B0=BF=E0=B0=B5=E0=B0=BE=E0=B0=B8=E0=B1=8D?= =?UTF-8?q?=20=20=E0=B0=A4=E0=B0=BE=E0=B0=9F=E0=B0=BF=E0=B0=AA=E0=B0=B0?= =?UTF-8?q?=E0=B1=8D=E0=B0=A4=E0=B0=BF=29?= Date: Fri, 19 Oct 2018 23:12:53 +0530 Subject: [PATCH] bpo-20216: Correct docstrings of digest() methods in hashlib. (GH-9873) --- Modules/_hashopenssl.c | 2 +- Modules/clinic/md5module.c.h | 4 ++-- Modules/clinic/sha1module.c.h | 4 ++-- Modules/clinic/sha256module.c.h | 4 ++-- Modules/clinic/sha512module.c.h | 4 ++-- Modules/md5module.c | 4 ++-- Modules/sha1module.c | 4 ++-- Modules/sha256module.c | 4 ++-- Modules/sha512module.c | 4 ++-- 9 files changed, 17 insertions(+), 17 deletions(-) diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c index 7121224e2ff..42ea9974b95 100644 --- a/Modules/_hashopenssl.c +++ b/Modules/_hashopenssl.c @@ -187,7 +187,7 @@ EVP_copy(EVPobject *self, PyObject *unused) } PyDoc_STRVAR(EVP_digest__doc__, -"Return the digest value as a string of binary data."); +"Return the digest value as a bytes object."); static PyObject * EVP_digest(EVPobject *self, PyObject *unused) diff --git a/Modules/clinic/md5module.c.h b/Modules/clinic/md5module.c.h index 850d76bace7..fa1a0d68e83 100644 --- a/Modules/clinic/md5module.c.h +++ b/Modules/clinic/md5module.c.h @@ -24,7 +24,7 @@ PyDoc_STRVAR(MD5Type_digest__doc__, "digest($self, /)\n" "--\n" "\n" -"Return the digest value as a string of binary data."); +"Return the digest value as a bytes object."); #define MD5TYPE_DIGEST_METHODDEF \ {"digest", (PyCFunction)MD5Type_digest, METH_NOARGS, MD5Type_digest__doc__}, @@ -94,4 +94,4 @@ _md5_md5(PyObject *module, PyObject *const *args, Py_ssize_t nargs, PyObject *kw exit: return return_value; } -/*[clinic end generated code: output=50a95670913de8fb input=a9049054013a1b77]*/ +/*[clinic end generated code: output=72aa003c308e26cf input=a9049054013a1b77]*/ diff --git a/Modules/clinic/sha1module.c.h b/Modules/clinic/sha1module.c.h index be29355e23f..c84fcbac5f6 100644 --- a/Modules/clinic/sha1module.c.h +++ b/Modules/clinic/sha1module.c.h @@ -24,7 +24,7 @@ PyDoc_STRVAR(SHA1Type_digest__doc__, "digest($self, /)\n" "--\n" "\n" -"Return the digest value as a string of binary data."); +"Return the digest value as a bytes object."); #define SHA1TYPE_DIGEST_METHODDEF \ {"digest", (PyCFunction)SHA1Type_digest, METH_NOARGS, SHA1Type_digest__doc__}, @@ -94,4 +94,4 @@ _sha1_sha1(PyObject *module, PyObject *const *args, Py_ssize_t nargs, PyObject * exit: return return_value; } -/*[clinic end generated code: output=9ee2aec7bb2b9e72 input=a9049054013a1b77]*/ +/*[clinic end generated code: output=81d2424c0585bfd4 input=a9049054013a1b77]*/ diff --git a/Modules/clinic/sha256module.c.h b/Modules/clinic/sha256module.c.h index 9de5bd087d9..45f78c8f795 100644 --- a/Modules/clinic/sha256module.c.h +++ b/Modules/clinic/sha256module.c.h @@ -24,7 +24,7 @@ PyDoc_STRVAR(SHA256Type_digest__doc__, "digest($self, /)\n" "--\n" "\n" -"Return the digest value as a string of binary data."); +"Return the digest value as a bytes object."); #define SHA256TYPE_DIGEST_METHODDEF \ {"digest", (PyCFunction)SHA256Type_digest, METH_NOARGS, SHA256Type_digest__doc__}, @@ -124,4 +124,4 @@ _sha256_sha224(PyObject *module, PyObject *const *args, Py_ssize_t nargs, PyObje exit: return return_value; } -/*[clinic end generated code: output=4b90199bc9f7cc88 input=a9049054013a1b77]*/ +/*[clinic end generated code: output=0086286cffcbc31c input=a9049054013a1b77]*/ diff --git a/Modules/clinic/sha512module.c.h b/Modules/clinic/sha512module.c.h index ebb510e39a6..9d3a7c9e6d4 100644 --- a/Modules/clinic/sha512module.c.h +++ b/Modules/clinic/sha512module.c.h @@ -24,7 +24,7 @@ PyDoc_STRVAR(SHA512Type_digest__doc__, "digest($self, /)\n" "--\n" "\n" -"Return the digest value as a string of binary data."); +"Return the digest value as a bytes object."); #define SHA512TYPE_DIGEST_METHODDEF \ {"digest", (PyCFunction)SHA512Type_digest, METH_NOARGS, SHA512Type_digest__doc__}, @@ -124,4 +124,4 @@ _sha512_sha384(PyObject *module, PyObject *const *args, Py_ssize_t nargs, PyObje exit: return return_value; } -/*[clinic end generated code: output=f963a543bf3c72e8 input=a9049054013a1b77]*/ +/*[clinic end generated code: output=fcc3306fb6672222 input=a9049054013a1b77]*/ diff --git a/Modules/md5module.c b/Modules/md5module.c index c66b27308f0..d377f0bb461 100644 --- a/Modules/md5module.c +++ b/Modules/md5module.c @@ -361,12 +361,12 @@ MD5Type_copy_impl(MD5object *self) /*[clinic input] MD5Type.digest -Return the digest value as a string of binary data. +Return the digest value as a bytes object. [clinic start generated code]*/ static PyObject * MD5Type_digest_impl(MD5object *self) -/*[clinic end generated code: output=eb691dc4190a07ec input=7b96e65389412a34]*/ +/*[clinic end generated code: output=eb691dc4190a07ec input=bc0c4397c2994be6]*/ { unsigned char digest[MD5_DIGESTSIZE]; struct md5_state temp; diff --git a/Modules/sha1module.c b/Modules/sha1module.c index 358cd1e7f9a..998ebd437df 100644 --- a/Modules/sha1module.c +++ b/Modules/sha1module.c @@ -338,12 +338,12 @@ SHA1Type_copy_impl(SHA1object *self) /*[clinic input] SHA1Type.digest -Return the digest value as a string of binary data. +Return the digest value as a bytes object. [clinic start generated code]*/ static PyObject * SHA1Type_digest_impl(SHA1object *self) -/*[clinic end generated code: output=2f05302a7aa2b5cb input=205d47e1927fd009]*/ +/*[clinic end generated code: output=2f05302a7aa2b5cb input=13824b35407444bd]*/ { unsigned char digest[SHA1_DIGESTSIZE]; struct sha1_state temp; diff --git a/Modules/sha256module.c b/Modules/sha256module.c index 3599eaf8be9..20b5f02f548 100644 --- a/Modules/sha256module.c +++ b/Modules/sha256module.c @@ -428,12 +428,12 @@ SHA256Type_copy_impl(SHAobject *self) /*[clinic input] SHA256Type.digest -Return the digest value as a string of binary data. +Return the digest value as a bytes object. [clinic start generated code]*/ static PyObject * SHA256Type_digest_impl(SHAobject *self) -/*[clinic end generated code: output=46616a5e909fbc3d input=1fb752e58954157d]*/ +/*[clinic end generated code: output=46616a5e909fbc3d input=f1f4cfea5cbde35c]*/ { unsigned char digest[SHA_DIGESTSIZE]; SHAobject temp; diff --git a/Modules/sha512module.c b/Modules/sha512module.c index d8c846a450f..e070e4389f4 100644 --- a/Modules/sha512module.c +++ b/Modules/sha512module.c @@ -493,12 +493,12 @@ SHA512Type_copy_impl(SHAobject *self) /*[clinic input] SHA512Type.digest -Return the digest value as a string of binary data. +Return the digest value as a bytes object. [clinic start generated code]*/ static PyObject * SHA512Type_digest_impl(SHAobject *self) -/*[clinic end generated code: output=1080bbeeef7dde1b input=60c2cede9e023018]*/ +/*[clinic end generated code: output=1080bbeeef7dde1b input=f6470dd359071f4b]*/ { unsigned char digest[SHA_DIGESTSIZE]; SHAobject temp;