From f05090372a43966266a8d20b9c21d348e417a48e Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Thu, 23 Feb 2012 20:49:08 +0000 Subject: [PATCH] Fix added for recent changes in non-threading environments. --- Lib/logging/__init__.py | 10 ++++++++-- Lib/logging/handlers.py | 25 ++++++++++++++++++++----- 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py index b4c823d36d9..4191b222a6c 100644 --- a/Lib/logging/__init__.py +++ b/Lib/logging/__init__.py @@ -917,9 +917,12 @@ class StreamHandler(Handler): """ Flushes the stream. """ - with self.lock: + self.acquire() + try: if self.stream and hasattr(self.stream, "flush"): self.stream.flush() + finally: + self.release() def emit(self, record): """ @@ -970,13 +973,16 @@ class FileHandler(StreamHandler): """ Closes the stream. """ - with self.lock: + self.acquire() + try: if self.stream: self.flush() if hasattr(self.stream, "close"): self.stream.close() StreamHandler.close(self) self.stream = None + finally: + self.release() def _open(self): """ diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py index 9fea2e8bf37..708edc51ac7 100644 --- a/Lib/logging/handlers.py +++ b/Lib/logging/handlers.py @@ -553,11 +553,14 @@ class SocketHandler(logging.Handler): """ Closes the socket. """ - with self.lock: + self.acquire() + try: if self.sock: self.sock.close() self.sock = None logging.Handler.close(self) + finally: + self.release() class DatagramHandler(SocketHandler): """ @@ -752,10 +755,13 @@ class SysLogHandler(logging.Handler): """ Closes the socket. """ - with self.lock: + self.acquire() + try: if self.unixsocket: self.socket.close() logging.Handler.close(self) + finally: + self.release() def mapPriority(self, levelName): """ @@ -1096,8 +1102,11 @@ class BufferingHandler(logging.Handler): This version just zaps the buffer to empty. """ - with self.lock: + self.acquire() + try: self.buffer = [] + finally: + self.release() def close(self): """ @@ -1147,20 +1156,26 @@ class MemoryHandler(BufferingHandler): The record buffer is also cleared by this operation. """ - with self.lock: + self.acquire() + try: if self.target: for record in self.buffer: self.target.handle(record) self.buffer = [] + finally: + self.release() def close(self): """ Flush, set the target to None and lose the buffer. """ self.flush() - with self.lock: + self.acquire() + try: self.target = None BufferingHandler.close(self) + finally: + self.release() class QueueHandler(logging.Handler):