From eaaaee8c569475614d16e3abf087228673bce9fc Mon Sep 17 00:00:00 2001 From: Yury Selivanov Date: Fri, 20 May 2016 17:44:19 -0400 Subject: [PATCH] asyncio: Fix getaddrinfo to accept None/str/bytes for 'port' arg Patch by A. Jesse Jiryu Davis. --- Lib/asyncio/base_events.py | 5 +++++ Lib/test/test_asyncio/test_base_events.py | 22 ++++++++++++++++++++++ 2 files changed, 27 insertions(+) diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py index 313cc316e53..e5e9394835f 100644 --- a/Lib/asyncio/base_events.py +++ b/Lib/asyncio/base_events.py @@ -102,6 +102,11 @@ def _ipaddr_info(host, port, family, type, proto): else: return None + if port in {None, ''}: + port = 0 + elif isinstance(port, (bytes, str)): + port = int(port) + if hasattr(socket, 'inet_pton'): if family == socket.AF_UNSPEC: afs = [socket.AF_INET, socket.AF_INET6] diff --git a/Lib/test/test_asyncio/test_base_events.py b/Lib/test/test_asyncio/test_base_events.py index ef93dc0e033..678ba30e39b 100644 --- a/Lib/test/test_asyncio/test_base_events.py +++ b/Lib/test/test_asyncio/test_base_events.py @@ -120,6 +120,28 @@ class BaseEventTests(test_utils.TestCase): (INET6, STREAM, TCP, '', ('::3%lo0', 1)), base_events._ipaddr_info('::3%lo0', 1, INET6, STREAM, TCP)) + def test_port_parameter_types(self): + # Test obscure kinds of arguments for "port". + INET = socket.AF_INET + STREAM = socket.SOCK_STREAM + TCP = socket.IPPROTO_TCP + + self.assertEqual( + (INET, STREAM, TCP, '', ('1.2.3.4', 0)), + base_events._ipaddr_info('1.2.3.4', None, INET, STREAM, TCP)) + + self.assertEqual( + (INET, STREAM, TCP, '', ('1.2.3.4', 0)), + base_events._ipaddr_info('1.2.3.4', '', INET, STREAM, TCP)) + + self.assertEqual( + (INET, STREAM, TCP, '', ('1.2.3.4', 1)), + base_events._ipaddr_info('1.2.3.4', '1', INET, STREAM, TCP)) + + self.assertEqual( + (INET, STREAM, TCP, '', ('1.2.3.4', 1)), + base_events._ipaddr_info('1.2.3.4', b'1', INET, STREAM, TCP)) + @patch_socket def test_ipaddr_info_no_inet_pton(self, m_socket): del m_socket.inet_pton