From 946f17214c5e344b4297d9d7f3d8abe2a399bb53 Mon Sep 17 00:00:00 2001 From: "Kurt B. Kaiser" Date: Fri, 25 Mar 2011 20:29:13 -0400 Subject: [PATCH] toggle failing on Tk 8.5, causing IDLE exits. Issue #4676 --- Lib/idlelib/EditorWindow.py | 21 +++++++++------------ Lib/idlelib/NEWS.txt | 5 ++++- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Lib/idlelib/EditorWindow.py b/Lib/idlelib/EditorWindow.py index 095bdf31a6b..98ec02bf7dd 100644 --- a/Lib/idlelib/EditorWindow.py +++ b/Lib/idlelib/EditorWindow.py @@ -307,10 +307,10 @@ class EditorWindow(object): if (event.state & 4) != 0 and event.keysym == "Home": # state&4==Control. If , use the Tk binding. return - if self.text.index("iomark") and \ self.text.compare("iomark", "<=", "insert lineend") and \ self.text.compare("insert linestart", "<=", "iomark"): + # In Shell on input line, go to just after prompt insertpt = int(self.text.index("iomark").split(".")[1]) else: line = self.text.get("insert linestart", "insert lineend") @@ -319,30 +319,27 @@ class EditorWindow(object): break else: insertpt=len(line) - lineat = int(self.text.index("insert").split('.')[1]) - if insertpt == lineat: insertpt = 0 - dest = "insert linestart+"+str(insertpt)+"c" - if (event.state&1) == 0: - # shift not pressed + # shift was not pressed self.text.tag_remove("sel", "1.0", "end") else: if not self.text.index("sel.first"): - self.text.mark_set("anchor","insert") - + self.text.mark_set("my_anchor", "insert") # there was no previous selection + else: + if self.text.compare(self.text.index("sel.first"), "<", self.text.index("insert")): + self.text.mark_set("my_anchor", "sel.first") # extend back + else: + self.text.mark_set("my_anchor", "sel.last") # extend forward first = self.text.index(dest) - last = self.text.index("anchor") - + last = self.text.index("my_anchor") if self.text.compare(first,">",last): first,last = last,first - self.text.tag_remove("sel", "1.0", "end") self.text.tag_add("sel", first, last) - self.text.mark_set("insert", dest) self.text.see("insert") return "break" diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index 7081d8020a9..6a031e1496f 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,7 +3,10 @@ What's New in IDLE 3.1.4? *Release date: XX-XXX-XX* -- toggle non-functional when NumLock set on Windows. Issue3851. +- toggle failing on Tk 8.5, causing IDLE exits and strange selection + behavior. Issue 4676. Improve selection extension behaviour. +- toggle non-functional when NumLock set on Windows. Issue 3851. + What's New in IDLE 3.1b1?