From c4c4842d8625db87bfdd916a3751f90e8a0f9d88 Mon Sep 17 00:00:00 2001 From: Matthias Klose Date: Sun, 21 Oct 2012 23:05:35 +0200 Subject: [PATCH] - Issue #16262: fix out-of-src-tree builds, if mercurial is not installed. --- Makefile.pre.in | 2 +- Misc/NEWS | 2 ++ configure | 39 ++++++++++++++++++++++----------------- configure.ac | 12 ++++++------ 4 files changed, 31 insertions(+), 24 deletions(-) diff --git a/Makefile.pre.in b/Makefile.pre.in index 91e28d2b503..44c1f15614b 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -280,7 +280,7 @@ AST_ASDL= $(srcdir)/Parser/Python.asdl ASDLGEN_FILES= $(srcdir)/Parser/asdl.py $(srcdir)/Parser/asdl_c.py # XXX Note that a build now requires Python exist before the build starts -ASDLGEN= @DISABLE_ASDLGEN@ $(srcdir)/Parser/asdl_c.py +ASDLGEN= @ASDLGEN@ $(srcdir)/Parser/asdl_c.py ########################################################################## # Python diff --git a/Misc/NEWS b/Misc/NEWS index 5069d47e1d5..5438245ba4c 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -590,6 +590,8 @@ Tests Build ----- +- Issue #16262: fix out-of-src-tree builds, if mercurial is not installed. + - Issue #15923: fix a mistake in asdl_c.py that resulted in a TypeError after 2801bf875a24 (see #15801). diff --git a/configure b/configure index c6223f6b090..708a0e198a3 100755 --- a/configure +++ b/configure @@ -645,8 +645,8 @@ MKDIR_P INSTALL_DATA INSTALL_SCRIPT INSTALL_PROGRAM -HAS_PYTHON -DISABLE_ASDLGEN +PYTHON +ASDLGEN HAS_HG HGBRANCH HGTAG @@ -5281,16 +5281,17 @@ else fi -DISABLE_ASDLGEN="" -# Extract the first word of "python", so it can be a program name with args. -set dummy python; ac_word=$2 +for ac_prog in python$PACKAGE_VERSION python3 python +do + # Extract the first word of "$ac_prog", so it can be a program name with args. +set dummy $ac_prog; ac_word=$2 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 $as_echo_n "checking for $ac_word... " >&6; } -if ${ac_cv_prog_HAS_PYTHON+:} false; then : +if ${ac_cv_prog_PYTHON+:} false; then : $as_echo_n "(cached) " >&6 else - if test -n "$HAS_PYTHON"; then - ac_cv_prog_HAS_PYTHON="$HAS_PYTHON" # Let the user override the test. + if test -n "$PYTHON"; then + ac_cv_prog_PYTHON="$PYTHON" # Let the user override the test. else as_save_IFS=$IFS; IFS=$PATH_SEPARATOR for as_dir in $PATH @@ -5299,7 +5300,7 @@ do test -z "$as_dir" && as_dir=. for ac_exec_ext in '' $ac_executable_extensions; do if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x "$as_dir/$ac_word$ac_exec_ext"; }; then - ac_cv_prog_HAS_PYTHON="found" + ac_cv_prog_PYTHON="$ac_prog" $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 break 2 fi @@ -5307,22 +5308,26 @@ done done IFS=$as_save_IFS - test -z "$ac_cv_prog_HAS_PYTHON" && ac_cv_prog_HAS_PYTHON="not-found" fi fi -HAS_PYTHON=$ac_cv_prog_HAS_PYTHON -if test -n "$HAS_PYTHON"; then - { $as_echo "$as_me:${as_lineno-$LINENO}: result: $HAS_PYTHON" >&5 -$as_echo "$HAS_PYTHON" >&6; } +PYTHON=$ac_cv_prog_PYTHON +if test -n "$PYTHON"; then + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $PYTHON" >&5 +$as_echo "$PYTHON" >&6; } else { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 $as_echo "no" >&6; } fi -if test $HAS_HG != found -o $HAS_PYTHON != found -then - DISABLE_ASDLGEN="@echo hg: $HAS_HG, python: $HAS_PYTHON! cannot run \$(srcdir)/Parser/asdl_c.py #" + test -n "$PYTHON" && break +done +test -n "$PYTHON" || PYTHON="not-found" + +if $PYTHON = not-found; then + ASDLGEN="@echo python: $PYTHON! cannot run \$(srcdir)/Parser/asdl_c.py #" +else + ASDLGEN="$PYTHON" fi diff --git a/configure.ac b/configure.ac index f2951a27fcd..3e05304c4b3 100644 --- a/configure.ac +++ b/configure.ac @@ -867,12 +867,12 @@ else HGBRANCH="" fi -AC_SUBST(DISABLE_ASDLGEN) -DISABLE_ASDLGEN="" -AC_CHECK_PROG(HAS_PYTHON, python, found, not-found) -if test $HAS_HG != found -o $HAS_PYTHON != found -then - DISABLE_ASDLGEN="@echo hg: $HAS_HG, python: $HAS_PYTHON! cannot run \$(srcdir)/Parser/asdl_c.py #" +AC_SUBST(ASDLGEN) +AC_CHECK_PROGS(PYTHON, python$PACKAGE_VERSION python3 python, not-found) +if $PYTHON = not-found; then + ASDLGEN="@echo python: $PYTHON! cannot run \$(srcdir)/Parser/asdl_c.py #" +else + ASDLGEN="$PYTHON" fi