From bf2b3b72d370f866aa5b8f9077ff37e7c53de894 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Sat, 30 May 2015 15:49:17 +0300 Subject: [PATCH] Use test.support.start_threads() in threaded lru_cache tests. --- Lib/test/test_functools.py | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/Lib/test/test_functools.py b/Lib/test/test_functools.py index 271d655dd09..e8cf8488764 100644 --- a/Lib/test/test_functools.py +++ b/Lib/test/test_functools.py @@ -1120,14 +1120,10 @@ class TestLRU: sys.setswitchinterval(1e-6) try: # create 5 threads in order to fill cache - threads = [] - for k in range(5): - t = threading.Thread(target=full, args=[f, k, k]) - t.start() - threads.append(t) - - for t in threads: - t.join() + threads = [threading.Thread(target=full, args=[f, k, k]) + for k in range(5)] + with support.start_threads(threads): + pass hits, misses, maxsize, currsize = f.cache_info() self.assertEqual(hits, 45) @@ -1135,16 +1131,11 @@ class TestLRU: self.assertEqual(currsize, 5) # create 5 threads in order to fill cache and 1 to clear it - cleaner = threading.Thread(target=clear, args=[f]) - cleaner.start() - threads = [cleaner] - for k in range(5): - t = threading.Thread(target=full, args=[f, k, k]) - t.start() - threads.append(t) - - for t in threads: - t.join() + threads = [threading.Thread(target=clear, args=[f])] + threads += [threading.Thread(target=full, args=[f, k, k]) + for k in range(5)] + with support.start_threads(threads): + pass finally: sys.setswitchinterval(orig_si)