From acb9fa79fa6453c2bbe3ccfc9cad2837feb90093 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 13 Sep 2017 10:10:10 -0700 Subject: [PATCH] bpo-31234, socket.create_connection(): Fix ref cycle (#3546) --- Lib/socket.py | 2 ++ .../next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst | 2 ++ 2 files changed, 4 insertions(+) create mode 100644 Misc/NEWS.d/next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst diff --git a/Lib/socket.py b/Lib/socket.py index 740e71782af..1ada24d3326 100644 --- a/Lib/socket.py +++ b/Lib/socket.py @@ -711,6 +711,8 @@ def create_connection(address, timeout=_GLOBAL_DEFAULT_TIMEOUT, if source_address: sock.bind(source_address) sock.connect(sa) + # Break explicitly a reference cycle + err = None return sock except error as _: diff --git a/Misc/NEWS.d/next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst b/Misc/NEWS.d/next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst new file mode 100644 index 00000000000..e522e8e9527 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst @@ -0,0 +1,2 @@ +socket.create_connection() now fixes manually a reference cycle: clear the +variable storing the last exception on success.