From a31f4cc881992e84d351957bd9ac1a92f882fa39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Lapeyre?= Date: Tue, 12 Feb 2019 01:37:24 +0100 Subject: [PATCH] bpo-35918: Remove broken has_key method and add test (#11819) --- Lib/multiprocessing/managers.py | 2 +- Lib/test/_test_multiprocessing.py | 2 -- .../next/Library/2019-02-11-16-23-10.bpo-35918.oGDlpT.rst | 2 ++ 3 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2019-02-11-16-23-10.bpo-35918.oGDlpT.rst diff --git a/Lib/multiprocessing/managers.py b/Lib/multiprocessing/managers.py index dbed993a38d..4ae8ddc7701 100644 --- a/Lib/multiprocessing/managers.py +++ b/Lib/multiprocessing/managers.py @@ -1135,7 +1135,7 @@ class ListProxy(BaseListProxy): DictProxy = MakeProxyType('DictProxy', ( '__contains__', '__delitem__', '__getitem__', '__iter__', '__len__', - '__setitem__', 'clear', 'copy', 'get', 'has_key', 'items', + '__setitem__', 'clear', 'copy', 'get', 'items', 'keys', 'pop', 'popitem', 'setdefault', 'update', 'values' )) DictProxy._method_to_typeid_ = { diff --git a/Lib/test/_test_multiprocessing.py b/Lib/test/_test_multiprocessing.py index d93303bb9cc..81db2c98705 100644 --- a/Lib/test/_test_multiprocessing.py +++ b/Lib/test/_test_multiprocessing.py @@ -4897,8 +4897,6 @@ class TestSyncManagerTypes(unittest.TestCase): assert len(obj) == 1 assert obj['foo'] == 5 assert obj.get('foo') == 5 - # TODO: fix https://bugs.python.org/issue35918 - # assert obj.has_key('foo') assert list(obj.items()) == [('foo', 5)] assert list(obj.keys()) == ['foo'] assert list(obj.values()) == [5] diff --git a/Misc/NEWS.d/next/Library/2019-02-11-16-23-10.bpo-35918.oGDlpT.rst b/Misc/NEWS.d/next/Library/2019-02-11-16-23-10.bpo-35918.oGDlpT.rst new file mode 100644 index 00000000000..0fcce3e2508 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2019-02-11-16-23-10.bpo-35918.oGDlpT.rst @@ -0,0 +1,2 @@ +Removed broken ``has_key`` method from +multiprocessing.managers.SyncManager.dict. Contributed by Rémi Lapeyre.