From 9ca3ffac94ad715e23787142aff4b7a465c4c744 Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Sun, 1 Jan 2012 16:04:29 -0600 Subject: [PATCH] == -1 is convention --- Objects/unicodeobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 3d8c8952f37..829f19c7259 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -8770,7 +8770,7 @@ _PyUnicode_TranslateCharmap(PyObject *input, collstart, collend, &newpos); if (repunicode == NULL) goto onError; - if (PyUnicode_READY(repunicode) < 0) { + if (PyUnicode_READY(repunicode) == -1) { Py_DECREF(repunicode); goto onError; }