From 9a27b0cd193cd97b51bb4d28942d318340cb54e8 Mon Sep 17 00:00:00 2001 From: Brian Curtin Date: Mon, 26 Jul 2010 00:27:10 +0000 Subject: [PATCH] =?UTF-8?q?Fix=20#7113.=20Patch=20by=20=C5=81ukasz=20Langa?= =?UTF-8?q?.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changes include using a list of lines instead of patching together using string interpolation, and a multi-line value test cases. --- Lib/configparser.py | 37 ++++++++++++++++++++------------ Lib/test/test_cfgparser.py | 44 ++++++++++++++++++++++++++++++++------ 2 files changed, 60 insertions(+), 21 deletions(-) diff --git a/Lib/configparser.py b/Lib/configparser.py index d11164fb67d..2fbedf82f5c 100644 --- a/Lib/configparser.py +++ b/Lib/configparser.py @@ -405,12 +405,11 @@ class RawConfigParser: for section in self._sections: fp.write("[%s]\n" % section) for (key, value) in self._sections[section].items(): - if key != "__name__": - if value is None: - fp.write("%s\n" % (key)) - else: - fp.write("%s = %s\n" % - (key, str(value).replace('\n', '\n\t'))) + if key == "__name__": + continue + if value is not None: + key = " = ".join((key, str(value).replace('\n', '\n\t'))) + fp.write("%s\n" % (key)) fp.write("\n") def remove_option(self, section, option): @@ -471,10 +470,10 @@ class RawConfigParser: leading whitespace. Blank lines, lines beginning with a '#', and just about everything else are ignored. """ - cursect = None # None, or a dictionary + cursect = None # None, or a dictionary optname = None lineno = 0 - e = None # None, or an exception + e = None # None, or an exception while True: line = fp.readline() if not line: @@ -490,7 +489,7 @@ class RawConfigParser: if line[0].isspace() and cursect is not None and optname: value = line.strip() if value: - cursect[optname] = "%s\n%s" % (cursect[optname], value) + cursect[optname].append(value) # a section header or option header? else: # is it a section header? @@ -515,6 +514,7 @@ class RawConfigParser: mo = self._optcre.match(line) if mo: optname, vi, optval = mo.group('option', 'vi', 'value') + optname = self.optionxform(optname.rstrip()) # This check is fine because the OPTCRE cannot # match if it would set optval to None if optval is not None: @@ -525,11 +525,13 @@ class RawConfigParser: if pos != -1 and optval[pos-1].isspace(): optval = optval[:pos] optval = optval.strip() - # allow empty values - if optval == '""': - optval = '' - optname = self.optionxform(optname.rstrip()) - cursect[optname] = optval + # allow empty values + if optval == '""': + optval = '' + cursect[optname] = [optval] + else: + # valueless option handling + cursect[optname] = optval else: # a non-fatal parsing error occurred. set up the # exception but keep going. the exception will be @@ -542,6 +544,13 @@ class RawConfigParser: if e: raise e + # join the multi-line values collected while reading + all_sections = [self._defaults] + all_sections.extend(self._sections.values()) + for options in all_sections: + for name, val in options.items(): + if isinstance(val, list): + options[name] = '\n'.join(val) class ConfigParser(RawConfigParser): diff --git a/Lib/test/test_cfgparser.py b/Lib/test/test_cfgparser.py index 5494bfcf547..c5a25954c02 100644 --- a/Lib/test/test_cfgparser.py +++ b/Lib/test/test_cfgparser.py @@ -1,7 +1,8 @@ +import collections import configparser import io +import os import unittest -import collections from test import support @@ -162,7 +163,7 @@ class TestCaseBase(unittest.TestCase): def test_parse_errors(self): self.newconfig() e = self.parse_error(configparser.ParsingError, - "[Foo]\n extra-spaces: splat\n") + "[Foo]\n extra-spaces: splat\n") self.assertEqual(e.args, ('',)) self.parse_error(configparser.ParsingError, "[Foo]\n extra-spaces= splat\n") @@ -171,7 +172,7 @@ class TestCaseBase(unittest.TestCase): self.parse_error(configparser.ParsingError, "[Foo]\n=value-without-option-name\n") e = self.parse_error(configparser.MissingSectionHeaderError, - "No Section!\n") + "No Section!\n") self.assertEqual(e.args, ('', 1, "No Section!\n")) def parse_error(self, exc, src): @@ -185,7 +186,8 @@ class TestCaseBase(unittest.TestCase): self.assertEqual(cf.sections(), [], "new ConfigParser should have no defined sections") self.assertFalse(cf.has_section("Foo"), - "new ConfigParser should have no acknowledged sections") + "new ConfigParser should have no acknowledged " + "sections") with self.assertRaises(configparser.NoSectionError) as cm: cf.options("Foo") with self.assertRaises(configparser.NoSectionError) as cm: @@ -355,8 +357,8 @@ class ConfigParserTestCase(TestCaseBase): def test_interpolation(self): rawval = { - configparser.ConfigParser: "something %(with11)s "\ - "lots of interpolation (11 steps)", + configparser.ConfigParser: ("something %(with11)s " + "lots of interpolation (11 steps)"), configparser.SafeConfigParser: "%(with1)s", } cf = self.get_interpolation_config() @@ -412,6 +414,33 @@ class ConfigParserTestCase(TestCaseBase): self.assertRaises(ValueError, cf.get, 'non-string', 'string_with_interpolation', raw=False) +class MultilineValuesTestCase(TestCaseBase): + config_class = configparser.ConfigParser + wonderful_spam = ("I'm having spam spam spam spam " + "spam spam spam beaked beans spam " + "spam spam and spam!").replace(' ', '\t\n') + + def setUp(self): + cf = self.newconfig() + for i in range(100): + s = 'section{}'.format(i) + cf.add_section(s) + for j in range(10): + cf.set(s, 'lovely_spam{}'.format(j), self.wonderful_spam) + with open(support.TESTFN, 'w') as f: + cf.write(f) + + def tearDown(self): + os.unlink(support.TESTFN) + + def test_dominating_multiline_values(self): + # We're reading from file because this is where the code changed + # during performance updates in Python 3.2 + cf_from_file = self.newconfig() + with open(support.TESTFN) as f: + cf_from_file.readfp(f) + self.assertEqual(cf_from_file.get('section8', 'lovely_spam4'), + self.wonderful_spam.replace('\t\n', '\n')) class RawConfigParserTestCase(TestCaseBase): config_class = configparser.RawConfigParser @@ -530,10 +559,11 @@ class SortedTestCase(RawConfigParserTestCase): def test_main(): support.run_unittest( ConfigParserTestCase, + MultilineValuesTestCase, RawConfigParserTestCase, SafeConfigParserTestCase, - SortedTestCase, SafeConfigParserTestCaseNoValue, + SortedTestCase, )