diff --git a/Lib/argparse.py b/Lib/argparse.py index 79f1fe5a6b4..0658472acf0 100644 --- a/Lib/argparse.py +++ b/Lib/argparse.py @@ -1312,13 +1312,13 @@ class _ActionsContainer(object): # create the action object, and add it to the parser action_class = self._pop_action_class(kwargs) if not _callable(action_class): - raise ValueError('unknown action "%s"' % action_class) + raise ValueError('unknown action "%s"' % (action_class,)) action = action_class(**kwargs) # raise an error if the action type is not callable type_func = self._registry_get('type', action.type, action.type) if not _callable(type_func): - raise ValueError('%r is not callable' % type_func) + raise ValueError('%r is not callable' % (type_func,)) # raise an error if the metavar does not match the type if hasattr(self, "_get_formatter"): diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py index 6ca1019c9a4..2836e7ec943 100644 --- a/Lib/test/test_argparse.py +++ b/Lib/test/test_argparse.py @@ -4082,10 +4082,12 @@ class TestInvalidArgumentConstructors(TestCase): def test_invalid_type(self): self.assertValueError('--foo', type='int') + self.assertValueError('--foo', type=(int, float)) def test_invalid_action(self): self.assertValueError('-x', action='foo') self.assertValueError('foo', action='baz') + self.assertValueError('--foo', action=('store', 'append')) parser = argparse.ArgumentParser() try: parser.add_argument("--foo", action="store-true") diff --git a/Misc/NEWS b/Misc/NEWS index 0b3d22d571e..e054baa6ecd 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -349,6 +349,8 @@ Library - Issue #9026: Fix order of argparse sub-commands in help messages. +- Issue #9347: Fix formatting for tuples in argparse type= error messages. + Build -----