From 6dc61b110fe9f5a30c6f37fab9e28c33fc6040cf Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Wed, 13 Aug 1997 14:48:36 +0000 Subject: [PATCH] Add try-finally to close the file after loading it in ModuleLoader.load_module! (Thanks to Daniel Larsson who complained about this.) --- Lib/ihooks.py | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/Lib/ihooks.py b/Lib/ihooks.py index dfe29cfea96..8f64957dd73 100644 --- a/Lib/ihooks.py +++ b/Lib/ihooks.py @@ -252,19 +252,22 @@ class ModuleLoader(BasicModuleLoader): def load_module(self, name, stuff): file, filename, (suff, mode, type) = stuff - if type == BUILTIN_MODULE: - return self.hooks.init_builtin(name) - if type == FROZEN_MODULE: - return self.hooks.init_frozen(name) - if type == C_EXTENSION: - m = self.hooks.load_dynamic(name, filename, file) - elif type == PY_SOURCE: - m = self.hooks.load_source(name, filename, file) - elif type == PY_COMPILED: - m = self.hooks.load_compiled(name, filename, file) - else: - raise ImportError, "Unrecognized module type (%s) for %s" % \ - (`type`, name) + try: + if type == BUILTIN_MODULE: + return self.hooks.init_builtin(name) + if type == FROZEN_MODULE: + return self.hooks.init_frozen(name) + if type == C_EXTENSION: + m = self.hooks.load_dynamic(name, filename, file) + elif type == PY_SOURCE: + m = self.hooks.load_source(name, filename, file) + elif type == PY_COMPILED: + m = self.hooks.load_compiled(name, filename, file) + else: + raise ImportError, "Unrecognized module type (%s) for %s" % \ + (`type`, name) + finally: + if file: file.close() m.__file__ = filename return m