From 4c483ad52b6f7760a0a861badae6c803d6ce8590 Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Thu, 8 Sep 2016 14:45:40 -0700 Subject: [PATCH] Merge --- Lib/test/test_set.py | 15 +++++++++++++++ Python/ceval.c | 6 ++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py index 49abfb3e713..afa6e7f1419 100644 --- a/Lib/test/test_set.py +++ b/Lib/test/test_set.py @@ -389,6 +389,21 @@ class TestSet(TestJointOps, unittest.TestCase): t = {1,2,3} self.assertEqual(s, t) + def test_set_literal_insertion_order(self): + # SF Issue #26020 -- Expect left to right insertion + s = {1, 1.0, True} + self.assertEqual(len(s), 1) + stored_value = s.pop() + self.assertEqual(type(stored_value), int) + + def test_set_literal_evaluation_order(self): + # Expect left to right expression evaluation + events = [] + def record(obj): + events.append(obj) + s = {record(1), record(2), record(3)} + self.assertEqual(events, [1, 2, 3]) + def test_hash(self): self.assertRaises(TypeError, hash, self.s) diff --git a/Python/ceval.c b/Python/ceval.c index 9109ea59f2a..0c3ef7b71b2 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -2619,14 +2619,16 @@ _PyEval_EvalFrameDefault(PyFrameObject *f, int throwflag) TARGET(BUILD_SET) { PyObject *set = PySet_New(NULL); int err = 0; + int i; if (set == NULL) goto error; - while (--oparg >= 0) { - PyObject *item = POP(); + for (i = oparg; i > 0; i--) { + PyObject *item = PEEK(i); if (err == 0) err = PySet_Add(set, item); Py_DECREF(item); } + STACKADJ(-oparg); if (err != 0) { Py_DECREF(set); goto error;