From 456ab1d2712dc9cebd878966c8fb16af47ea79f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20v=2E=20L=C3=B6wis?= Date: Thu, 6 May 2004 01:54:36 +0000 Subject: [PATCH] Swap public and system ID in start_doctype_decl. Fixes #780300. --- Doc/whatsnew/whatsnew24.tex | 4 ++++ Lib/xml/sax/expatreader.py | 2 +- Misc/NEWS | 3 +++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Doc/whatsnew/whatsnew24.tex b/Doc/whatsnew/whatsnew24.tex index 8e2b11ec319..ff8a3fa1cea 100644 --- a/Doc/whatsnew/whatsnew24.tex +++ b/Doc/whatsnew/whatsnew24.tex @@ -561,6 +561,10 @@ changes to your code: \item \function{dircache.listdir()} now passes exceptions to the caller instead of returning empty lists. +\item \function{LexicalHandler.startDTD} used to receive public and system ID + in the wrong order. This has been corrected; applications relying on the + wrong order need to be fixed. + \end{itemize} diff --git a/Lib/xml/sax/expatreader.py b/Lib/xml/sax/expatreader.py index 58ad7735811..ab8cbc1244b 100644 --- a/Lib/xml/sax/expatreader.py +++ b/Lib/xml/sax/expatreader.py @@ -361,7 +361,7 @@ class ExpatParser(xmlreader.IncrementalParser, xmlreader.Locator): def end_namespace_decl(self, prefix): self._cont_handler.endPrefixMapping(prefix) - def start_doctype_decl(self, name, pubid, sysid, has_internal_subset): + def start_doctype_decl(self, name, sysid, pubid, has_internal_subset): self._lex_handler_prop.startDTD(name, pubid, sysid) def unparsed_entity_decl(self, name, base, sysid, pubid, notation_name): diff --git a/Misc/NEWS b/Misc/NEWS index 983c5488829..809d2d972cb 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -306,6 +306,9 @@ Extension modules Library ------- +- Bug #780300: Swap public and system ID in LexicalHandler.startDTD. + Applications relying on the wrong order need to be corrected. + - Bug #926075: Fixed a bug that returns a wrong pattern object for a string or unicode object in sre.compile() when a different type pattern with the same value exists.