traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-35518: Skip test that relies on a deceased network service. (GH-15349) 

If this service had thoroughly vanished, we could just ignore the
test until someone gets around to either recreating such a service
or redesigning the test to somehow work locally.  The
`support.transient_internet` mechanism catches the failure to
resolve the domain name, and skips the test.

But in fact the domain snakebite.net does still exist, as do its
nameservers -- and they can be quite slow to reply.  As a result
this test can easily take 20-30s before it gets auto-skipped.

So, skip the test explicitly up front.
(cherry picked from commit 5b95a1507e)

Co-authored-by: Greg Price <gnprice@gmail.com>
This commit is contained in:
Miss Islington (bot) 2019-08-20 21:08:57 -07:00 committed by GitHub
parent 30e5aff5fb
commit 44f2c09680
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Lib/test/test_timeout.py
View File

@ -150,6 +150,7 @@ class TCPTimeoutTestCase(TimeoutTestCase):
def tearDown(self): def tearDown(self):
self.sock.close() self.sock.close()
@unittest.skipIf(True, 'need to replace these hosts; see bpo-35518')
def testConnectTimeout(self): def testConnectTimeout(self):
# Testing connect timeout is tricky: we need to have IP connectivity # Testing connect timeout is tricky: we need to have IP connectivity
# to a host that silently drops our packets. We can't simulate this # to a host that silently drops our packets. We can't simulate this