From 35e48d2426e50306cb957da26777b1e3469c53b3 Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Mon, 25 Nov 2002 20:43:55 +0000 Subject: [PATCH] SF 643115: Set._update() had a special case for dictionaries which allowed non-true values to leak in. This threw-off equality testing which depends on the underlying dictionaries having both the same keys and values. --- Lib/sets.py | 3 --- Lib/test/test_sets.py | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Lib/sets.py b/Lib/sets.py index 5dac370a644..2605c98fd09 100644 --- a/Lib/sets.py +++ b/Lib/sets.py @@ -315,9 +315,6 @@ class BaseSet(object): if isinstance(iterable, BaseSet): data.update(iterable._data) return - if isinstance(iterable, dict): - data.update(iterable) - return value = True diff --git a/Lib/test/test_sets.py b/Lib/test/test_sets.py index 9bc3eeba748..f80d58e82ef 100644 --- a/Lib/test/test_sets.py +++ b/Lib/test/test_sets.py @@ -179,6 +179,9 @@ class TestBinaryOps(unittest.TestCase): def setUp(self): self.set = Set((2, 4, 6)) + def test_eq(self): # SF bug 643115 + self.assertEqual(self.set, Set({2:1,4:3,6:5})) + def test_union_subset(self): result = self.set | Set([2]) self.assertEqual(result, Set((2, 4, 6)))