From 2dd4abf27769d6c1c04310d83374f30e229826ea Mon Sep 17 00:00:00 2001 From: Barry Warsaw Date: Fri, 18 Aug 2000 06:58:15 +0000 Subject: [PATCH] PyUnicode_AsUTF8String(): Don't need to explicitly incref str since PyUnicode_EncodeUTF8() already returns the created object with the proper reference count. This fixes an Insure reported memory leak. --- Objects/unicodeobject.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index f4dc9bfe7e6..1d35c3d3805 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -907,13 +907,9 @@ PyObject *PyUnicode_AsUTF8String(PyObject *unicode) PyErr_BadArgument(); return NULL; } - str = PyUnicode_EncodeUTF8(PyUnicode_AS_UNICODE(unicode), - PyUnicode_GET_SIZE(unicode), - NULL); - if (str == NULL) - return NULL; - Py_INCREF(str); - return str; + return PyUnicode_EncodeUTF8(PyUnicode_AS_UNICODE(unicode), + PyUnicode_GET_SIZE(unicode), + NULL); } /* --- UTF-16 Codec ------------------------------------------------------- */