diff --git a/.github/workflows/build_msi.yml b/.github/workflows/build_msi.yml new file mode 100644 index 00000000000..e9ecf547275 --- /dev/null +++ b/.github/workflows/build_msi.yml @@ -0,0 +1,34 @@ +name: TestsMSI + +on: + push: + branches: + - master + - 3.8 + - 3.7 + paths: + - 'Tools/msi/**' + pull_request: + branches: + - master + - 3.8 + - 3.7 + paths: + - 'Tools/msi/**' + +jobs: + build_win32: + name: 'Windows (x86) Installer' + runs-on: windows-latest + steps: + - uses: actions/checkout@v1 + - name: Build CPython installer + run: .\Tools\msi\build.bat -x86 + + build_win_amd64: + name: 'Windows (x64) Installer' + runs-on: windows-latest + steps: + - uses: actions/checkout@v1 + - name: Build CPython installer + run: .\Tools\msi\build.bat -x64 diff --git a/Misc/NEWS.d/next/Windows/2020-03-11-10-15-56.bpo-39930.LGHw1j.rst b/Misc/NEWS.d/next/Windows/2020-03-11-10-15-56.bpo-39930.LGHw1j.rst new file mode 100644 index 00000000000..c3011897b6d --- /dev/null +++ b/Misc/NEWS.d/next/Windows/2020-03-11-10-15-56.bpo-39930.LGHw1j.rst @@ -0,0 +1,2 @@ +Ensures the required :file:`vcruntime140.dll` is included in install +packages. diff --git a/PCbuild/pyproject.props b/PCbuild/pyproject.props index c4c07c59903..0bbdcfa1dbf 100644 --- a/PCbuild/pyproject.props +++ b/PCbuild/pyproject.props @@ -199,4 +199,25 @@ public override bool Execute() { + + + + + $(VCInstallDir)\Redist\MSVC\$(VCToolsRedistVersion)\ + $(VCRedistDir)x86\ + $(VCRedistDir)$(Platform)\ + + + $(VCInstallDir)\redist\ + $(VCRedistDir)x86\ + $(VCRedistDir)$(Platform)\ + + + + + + + + + diff --git a/PCbuild/pythoncore.vcxproj b/PCbuild/pythoncore.vcxproj index ac73a912630..30603b0c54d 100644 --- a/PCbuild/pythoncore.vcxproj +++ b/PCbuild/pythoncore.vcxproj @@ -527,15 +527,7 @@ - - $(VCInstallDir)\Redist\MSVC\$(VCToolsRedistVersion)\ - $(VCRedistDir)x86\ - $(VCRedistDir)$(Platform)\ - - - - - + diff --git a/Tools/msi/exe/exe.wixproj b/Tools/msi/exe/exe.wixproj index 326766bf2d4..be44f442f7c 100644 --- a/Tools/msi/exe/exe.wixproj +++ b/Tools/msi/exe/exe.wixproj @@ -11,6 +11,9 @@ ICE43 + + $(DefineConstants);Include_Vcruntime140_1_dll=1 + diff --git a/Tools/msi/exe/exe_files.wxs b/Tools/msi/exe/exe_files.wxs index 483d06c65b2..15bf6a06634 100644 --- a/Tools/msi/exe/exe_files.wxs +++ b/Tools/msi/exe/exe_files.wxs @@ -30,8 +30,13 @@ - + + + + + +