From 1580fe3fcebcfe0b657281a6a556975c072a5530 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 23 Jun 2014 00:31:08 +0200 Subject: [PATCH] asyncio, Tulip issue 172: only log selector timing in debug mode --- Lib/asyncio/base_events.py | 3 +-- Lib/test/test_asyncio/test_base_events.py | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py index 0975bcb6fc3..2f7f1979d3e 100644 --- a/Lib/asyncio/base_events.py +++ b/Lib/asyncio/base_events.py @@ -834,8 +834,7 @@ class BaseEventLoop(events.AbstractEventLoop): when = self._scheduled[0]._when timeout = max(0, when - self.time()) - # TODO: Instrumentation only in debug mode? - if logger.isEnabledFor(logging.INFO): + if self._debug: t0 = self.time() event_list = self._selector.select(timeout) dt = self.time() - t0 diff --git a/Lib/test/test_asyncio/test_base_events.py b/Lib/test/test_asyncio/test_base_events.py index b238f4ea01f..9fa3e6d25c5 100644 --- a/Lib/test/test_asyncio/test_base_events.py +++ b/Lib/test/test_asyncio/test_base_events.py @@ -247,6 +247,9 @@ class BaseEventLoopTests(test_utils.TestCase): time.sleep(1.0) return [] + # logging needs debug flag + self.loop.set_debug(True) + # Log to INFO level if timeout > 1.0 sec. self.loop._selector.select = slow_select self.loop._process_events = mock.Mock()