From 9d20dea3b866192ac16638c7e753bf3a58e7a5b9 Mon Sep 17 00:00:00 2001 From: Lorenz Meier Date: Fri, 12 Feb 2021 22:35:56 +0100 Subject: [PATCH] Rover: remove unused parameter --- .../init.d-posix/airframes/1060_rover | 1 - .../init.d-posix/airframes/1061_r1_rover | 1 - .../init.d-posix/airframes/1062_tf-r1 | 1 - .../init.d-posix/airframes/1070_boat | 1 - .../init.d/airframes/50000_generic_ground_vehicle | 1 - .../init.d/airframes/50003_aion_robotics_r1_rover | 1 - .../init.d/airframes/50004_nxpcup_car_dfrobot_gpx | 1 - .../rover_pos_control/rover_pos_control_params.c | 15 --------------- 8 files changed, 22 deletions(-) diff --git a/ROMFS/px4fmu_common/init.d-posix/airframes/1060_rover b/ROMFS/px4fmu_common/init.d-posix/airframes/1060_rover index dcb0500f09..d2400bec18 100644 --- a/ROMFS/px4fmu_common/init.d-posix/airframes/1060_rover +++ b/ROMFS/px4fmu_common/init.d-posix/airframes/1060_rover @@ -16,7 +16,6 @@ then param set GND_SPEED_THR_SC 1 param set GND_SPEED_TRIM 4 param set GND_THR_CRUISE 0.3 - param set GND_THR_IDLE 0 param set GND_THR_MAX 0.5 param set GND_THR_MIN 0 diff --git a/ROMFS/px4fmu_common/init.d-posix/airframes/1061_r1_rover b/ROMFS/px4fmu_common/init.d-posix/airframes/1061_r1_rover index 1d3a436cc2..ddd04393a1 100644 --- a/ROMFS/px4fmu_common/init.d-posix/airframes/1061_r1_rover +++ b/ROMFS/px4fmu_common/init.d-posix/airframes/1061_r1_rover @@ -17,7 +17,6 @@ then param set GND_SPEED_THR_SC 1 param set GND_SPEED_TRIM 4 param set GND_THR_CRUISE 0.3 - param set GND_THR_IDLE 0 param set GND_THR_MAX 0.5 param set GND_THR_MIN 0 diff --git a/ROMFS/px4fmu_common/init.d-posix/airframes/1062_tf-r1 b/ROMFS/px4fmu_common/init.d-posix/airframes/1062_tf-r1 index 80d70249f4..43743a2be9 100644 --- a/ROMFS/px4fmu_common/init.d-posix/airframes/1062_tf-r1 +++ b/ROMFS/px4fmu_common/init.d-posix/airframes/1062_tf-r1 @@ -22,7 +22,6 @@ then param set GND_SPEED_TRIM 15 param set GND_SPEED_MAX 25 param set GND_THR_CRUISE 0.3 - param set GND_THR_IDLE 0 param set GND_THR_MAX 0.5 param set GND_THR_MIN 0 diff --git a/ROMFS/px4fmu_common/init.d-posix/airframes/1070_boat b/ROMFS/px4fmu_common/init.d-posix/airframes/1070_boat index cac17b7f86..a8c1b52f74 100644 --- a/ROMFS/px4fmu_common/init.d-posix/airframes/1070_boat +++ b/ROMFS/px4fmu_common/init.d-posix/airframes/1070_boat @@ -17,7 +17,6 @@ then param set GND_SPEED_THR_SC 1 param set GND_SPEED_TRIM 1 param set GND_THR_CRUISE 0.85 - param set GND_THR_IDLE 0 param set GND_THR_MAX 1 param set GND_THR_MIN 0 diff --git a/ROMFS/px4fmu_common/init.d/airframes/50000_generic_ground_vehicle b/ROMFS/px4fmu_common/init.d/airframes/50000_generic_ground_vehicle index f21f131435..e6c09ecbd2 100644 --- a/ROMFS/px4fmu_common/init.d/airframes/50000_generic_ground_vehicle +++ b/ROMFS/px4fmu_common/init.d/airframes/50000_generic_ground_vehicle @@ -34,7 +34,6 @@ param set-default GND_SPEED_I 3 param set-default GND_SPEED_D 0.001 param set-default GND_SPEED_IMAX 0.125 param set-default GND_SPEED_THR_SC 1 -param set-default GND_THR_IDLE 0 param set-default GND_THR_CRUISE 0.3 param set-default GND_THR_MAX 0.5 param set-default GND_THR_MIN 0 diff --git a/ROMFS/px4fmu_common/init.d/airframes/50003_aion_robotics_r1_rover b/ROMFS/px4fmu_common/init.d/airframes/50003_aion_robotics_r1_rover index 3000f92354..c36e815517 100644 --- a/ROMFS/px4fmu_common/init.d/airframes/50003_aion_robotics_r1_rover +++ b/ROMFS/px4fmu_common/init.d/airframes/50003_aion_robotics_r1_rover @@ -35,7 +35,6 @@ param set-default FW_AIRSPD_MAX 3 param set-default GND_SP_CTRL_MODE 1 param set-default GND_L1_DIST 5 param set-default GND_L1_PERIOD 3 -param set-default GND_THR_IDLE 0 param set-default GND_THR_CRUISE 0.7 param set-default GND_THR_MAX 0.5 diff --git a/ROMFS/px4fmu_common/init.d/airframes/50004_nxpcup_car_dfrobot_gpx b/ROMFS/px4fmu_common/init.d/airframes/50004_nxpcup_car_dfrobot_gpx index 85c4b9dfd7..73fdffb03c 100644 --- a/ROMFS/px4fmu_common/init.d/airframes/50004_nxpcup_car_dfrobot_gpx +++ b/ROMFS/px4fmu_common/init.d/airframes/50004_nxpcup_car_dfrobot_gpx @@ -32,7 +32,6 @@ param set-default FW_AIRSPD_MIN 0 param set-default FW_AIRSPD_TRIM 1 param set-default FW_AIRSPD_MAX 3 -param set-default GND_THR_IDLE 0 param set-default GND_THR_CRUISE 0.3 param set-default GND_THR_MAX 0.5 diff --git a/src/modules/rover_pos_control/rover_pos_control_params.c b/src/modules/rover_pos_control/rover_pos_control_params.c index cc3b639b12..e168732ef5 100644 --- a/src/modules/rover_pos_control/rover_pos_control_params.c +++ b/src/modules/rover_pos_control/rover_pos_control_params.c @@ -138,21 +138,6 @@ PARAM_DEFINE_FLOAT(GND_THR_MAX, 0.3f); */ PARAM_DEFINE_FLOAT(GND_THR_MIN, 0.0f); -/** - * Idle throttle - * - * This is the minimum throttle while on the ground, it should be 0 for a rover - * - * - * @unit norm - * @min 0.0 - * @max 0.4 - * @decimal 2 - * @increment 0.01 - * @group Rover Position Control - */ -PARAM_DEFINE_FLOAT(GND_THR_IDLE, 0.0f); - /** * Control mode for speed *