From 17c1114b3ecb510770b99ca76a353de1937820ea Mon Sep 17 00:00:00 2001 From: Daniel Agar Date: Sat, 13 May 2017 16:03:52 -0400 Subject: [PATCH] clang-tidy readability-named-parameter --- .clang-tidy | 1 - src/lib/DriverFramework | 2 +- src/modules/simulator/simulator_mavlink.cpp | 2 +- src/modules/uORB/Subscription.hpp | 2 +- src/modules/uORB/uORB_tests/uORBTest_UnitTest.hpp | 3 ++- src/platforms/posix/drivers/gyrosim/gyrosim.cpp | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 5fa0938dd2..d3d8312eff 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -62,7 +62,6 @@ Checks: '* ,-readability-else-after-return ,-readability-implicit-bool-cast ,-readability-inconsistent-declaration-parameter-name - ,-readability-named-parameter ,-readability-non-const-parameter ,-readability-redundant-declaration ,-readability-redundant-member-init diff --git a/src/lib/DriverFramework b/src/lib/DriverFramework index a2ef69ec51..f80732f1b1 160000 --- a/src/lib/DriverFramework +++ b/src/lib/DriverFramework @@ -1 +1 @@ -Subproject commit a2ef69ec51579947d76accec427ca8f74a7938f7 +Subproject commit f80732f1b157c18f4b520b981f705b87f87a7ac8 diff --git a/src/modules/simulator/simulator_mavlink.cpp b/src/modules/simulator/simulator_mavlink.cpp index 4b3aae08e6..c9a1cccf07 100644 --- a/src/modules/simulator/simulator_mavlink.cpp +++ b/src/modules/simulator/simulator_mavlink.cpp @@ -528,7 +528,7 @@ void Simulator::poll_topics() } } -void *Simulator::sending_trampoline(void *) +void *Simulator::sending_trampoline(void * /*unused*/) { _instance->send(); return nullptr; diff --git a/src/modules/uORB/Subscription.hpp b/src/modules/uORB/Subscription.hpp index 16ccf34cef..599dcf33f8 100644 --- a/src/modules/uORB/Subscription.hpp +++ b/src/modules/uORB/Subscription.hpp @@ -173,7 +173,7 @@ public: int instance = 0, List *list = nullptr); - Subscription(const Subscription &); + Subscription(const Subscription & /*other*/); /** * Deconstructor diff --git a/src/modules/uORB/uORB_tests/uORBTest_UnitTest.hpp b/src/modules/uORB/uORB_tests/uORBTest_UnitTest.hpp index c574e2559d..2c368ddd73 100644 --- a/src/modules/uORB/uORB_tests/uORBTest_UnitTest.hpp +++ b/src/modules/uORB/uORB_tests/uORBTest_UnitTest.hpp @@ -84,7 +84,8 @@ private: UnitTest() : pubsubtest_passed(false), pubsubtest_print(false) {} // Disallow copy - UnitTest(const uORBTest::UnitTest &) {}; + UnitTest(const uORBTest::UnitTest & /*unused*/) = delete; + static int pubsubtest_threadEntry(char *const argv[]); int pubsublatency_main(); diff --git a/src/platforms/posix/drivers/gyrosim/gyrosim.cpp b/src/platforms/posix/drivers/gyrosim/gyrosim.cpp index f1d5684c98..225ebb1be3 100644 --- a/src/platforms/posix/drivers/gyrosim/gyrosim.cpp +++ b/src/platforms/posix/drivers/gyrosim/gyrosim.cpp @@ -1221,7 +1221,7 @@ namespace gyrosim GYROSIM *g_dev_sim; // on simulated bus -int start(enum Rotation); +int start(enum Rotation /*rotation*/); int stop(); int test(); int reset();