From fa7e34aaa36eaf8a3912331c0b9d846b8b064f42 Mon Sep 17 00:00:00 2001 From: Gustavo Jose de Sousa Date: Tue, 11 Aug 2015 16:28:46 +1000 Subject: [PATCH] Filter: standardize inclusion of libaries headers This commit changes the way libraries headers are included in source files: - If the header is in the same directory the source belongs to, so the notation '#include ""' is used with the path relative to the directory containing the source. - If the header is outside the directory containing the source, then we use the notation '#include <>' with the path relative to libraries folder. Some of the advantages of such approach: - Only one search path for libraries headers. - OSs like Windows may have a better lookup time. --- libraries/Filter/Butter.h | 2 +- libraries/Filter/DerivativeFilter.cpp | 6 ++--- libraries/Filter/LowPassFilter.h | 2 +- libraries/Filter/LowPassFilter2p.cpp | 2 +- .../Filter/examples/Derivative/Derivative.cpp | 18 +++++++------- libraries/Filter/examples/Filter/Filter.cpp | 24 +++++++++---------- .../examples/LowPassFilter/LowPassFilter.cpp | 18 +++++++------- .../LowPassFilter2p/LowPassFilter2p.cpp | 22 ++++++++--------- 8 files changed, 47 insertions(+), 47 deletions(-) diff --git a/libraries/Filter/Butter.h b/libraries/Filter/Butter.h index 7c36dcc113..1a49617bc3 100644 --- a/libraries/Filter/Butter.h +++ b/libraries/Filter/Butter.h @@ -2,7 +2,7 @@ #ifndef __FILTER_BUTTER_H__ #define __FILTER_BUTTER_H__ -#include +#include template class Butter2 diff --git a/libraries/Filter/DerivativeFilter.cpp b/libraries/Filter/DerivativeFilter.cpp index db4e990ddc..6a86f964ca 100644 --- a/libraries/Filter/DerivativeFilter.cpp +++ b/libraries/Filter/DerivativeFilter.cpp @@ -19,9 +19,9 @@ /// See http://www.holoborodko.com/pavel/numerical-methods/numerical-derivative/smooth-low-noise-differentiators/ // #include -#include -#include -#include +#include +#include "Filter.h" +#include "DerivativeFilter.h" template diff --git a/libraries/Filter/LowPassFilter.h b/libraries/Filter/LowPassFilter.h index c9cf775331..c551c18537 100644 --- a/libraries/Filter/LowPassFilter.h +++ b/libraries/Filter/LowPassFilter.h @@ -23,7 +23,7 @@ #ifndef __LOW_PASS_FILTER_H__ #define __LOW_PASS_FILTER_H__ -#include +#include #include "FilterClass.h" // DigitalLPF implements the filter math diff --git a/libraries/Filter/LowPassFilter2p.cpp b/libraries/Filter/LowPassFilter2p.cpp index 7ac93b004d..dbd0972dc3 100644 --- a/libraries/Filter/LowPassFilter2p.cpp +++ b/libraries/Filter/LowPassFilter2p.cpp @@ -20,7 +20,7 @@ /// Author: Leonard Hall #include -#include +#include #include "LowPassFilter2p.h" float DigitalBiquadFilter::apply(float sample, const struct biquad_params ¶ms) diff --git a/libraries/Filter/examples/Derivative/Derivative.cpp b/libraries/Filter/examples/Derivative/Derivative.cpp index 58cb28f943..6721eaf151 100644 --- a/libraries/Filter/examples/Derivative/Derivative.cpp +++ b/libraries/Filter/examples/Derivative/Derivative.cpp @@ -3,15 +3,15 @@ */ #include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER; diff --git a/libraries/Filter/examples/Filter/Filter.cpp b/libraries/Filter/examples/Filter/Filter.cpp index b2a82265d6..8899650b76 100644 --- a/libraries/Filter/examples/Filter/Filter.cpp +++ b/libraries/Filter/examples/Filter/Filter.cpp @@ -3,18 +3,18 @@ * Code by Randy Mackay and Jason Short. DIYDrones.com */ -#include -#include -#include -#include -#include -#include -#include -#include -#include // ArduPilot Mega Vector/Matrix math Library -#include // Filter library -#include // ModeFilter class (inherits from Filter class) -#include // AverageFilter class (inherits from Filter class) +#include +#include +#include +#include +#include +#include +#include +#include +#include // ArduPilot Mega Vector/Matrix math Library +#include // Filter library +#include // ModeFilter class (inherits from Filter class) +#include // AverageFilter class (inherits from Filter class) const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER; diff --git a/libraries/Filter/examples/LowPassFilter/LowPassFilter.cpp b/libraries/Filter/examples/LowPassFilter/LowPassFilter.cpp index 9de96aa54f..cd92b2b109 100644 --- a/libraries/Filter/examples/LowPassFilter/LowPassFilter.cpp +++ b/libraries/Filter/examples/LowPassFilter/LowPassFilter.cpp @@ -3,15 +3,15 @@ * Code by Randy Mackay. DIYDrones.com */ -#include -#include -#include -#include -#include -#include -#include // ArduPilot Mega Vector/Matrix math Library -#include // Filter library -#include // LowPassFilter class (inherits from Filter class) +#include +#include +#include +#include +#include +#include +#include // ArduPilot Mega Vector/Matrix math Library +#include // Filter library +#include // LowPassFilter class (inherits from Filter class) const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER; diff --git a/libraries/Filter/examples/LowPassFilter2p/LowPassFilter2p.cpp b/libraries/Filter/examples/LowPassFilter2p/LowPassFilter2p.cpp index 465045275a..31b84e9a8d 100644 --- a/libraries/Filter/examples/LowPassFilter2p/LowPassFilter2p.cpp +++ b/libraries/Filter/examples/LowPassFilter2p/LowPassFilter2p.cpp @@ -3,17 +3,17 @@ * Code by Randy Mackay and Andrew Tridgell */ -#include -#include -#include -#include -#include -#include -#include -#include -#include // ArduPilot Mega Vector/Matrix math Library -#include // Filter library -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include // ArduPilot Mega Vector/Matrix math Library +#include // Filter library +#include const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER;