From 0c67f20a7448c9c5ab804165929a4b6d571cda48 Mon Sep 17 00:00:00 2001 From: Asif Khan Date: Thu, 13 Jul 2023 23:46:47 +0530 Subject: [PATCH] AP_Mount: fix setting default mode redundantly in each backend --- libraries/AP_Mount/AP_Mount_Alexmos.cpp | 1 - libraries/AP_Mount/AP_Mount_SToRM32_serial.cpp | 1 - libraries/AP_Mount/AP_Mount_Siyi.cpp | 1 - libraries/AP_Mount/AP_Mount_SoloGimbal.cpp | 1 - 4 files changed, 4 deletions(-) diff --git a/libraries/AP_Mount/AP_Mount_Alexmos.cpp b/libraries/AP_Mount/AP_Mount_Alexmos.cpp index f58796204d..1b831edc01 100644 --- a/libraries/AP_Mount/AP_Mount_Alexmos.cpp +++ b/libraries/AP_Mount/AP_Mount_Alexmos.cpp @@ -12,7 +12,6 @@ void AP_Mount_Alexmos::init() _initialised = true; get_boardinfo(); read_params(0); //we request parameters for profile 0 and therfore get global and profile parameters - set_mode((enum MAV_MOUNT_MODE)_params.default_mode.get()); } AP_Mount_Backend::init(); } diff --git a/libraries/AP_Mount/AP_Mount_SToRM32_serial.cpp b/libraries/AP_Mount/AP_Mount_SToRM32_serial.cpp index 73a2617c3a..9f94ab0a70 100644 --- a/libraries/AP_Mount/AP_Mount_SToRM32_serial.cpp +++ b/libraries/AP_Mount/AP_Mount_SToRM32_serial.cpp @@ -14,7 +14,6 @@ void AP_Mount_SToRM32_serial::init() _port = serial_manager.find_serial(AP_SerialManager::SerialProtocol_Gimbal, 0); if (_port) { _initialised = true; - set_mode((enum MAV_MOUNT_MODE)_params.default_mode.get()); } AP_Mount_Backend::init(); diff --git a/libraries/AP_Mount/AP_Mount_Siyi.cpp b/libraries/AP_Mount/AP_Mount_Siyi.cpp index da56c40057..ee60bbf00c 100644 --- a/libraries/AP_Mount/AP_Mount_Siyi.cpp +++ b/libraries/AP_Mount/AP_Mount_Siyi.cpp @@ -31,7 +31,6 @@ void AP_Mount_Siyi::init() _uart = serial_manager.find_serial(AP_SerialManager::SerialProtocol_Gimbal, 0); if (_uart != nullptr) { _initialised = true; - set_mode((enum MAV_MOUNT_MODE)_params.default_mode.get()); } AP_Mount_Backend::init(); } diff --git a/libraries/AP_Mount/AP_Mount_SoloGimbal.cpp b/libraries/AP_Mount/AP_Mount_SoloGimbal.cpp index 4575a69ebd..2643eb3694 100644 --- a/libraries/AP_Mount/AP_Mount_SoloGimbal.cpp +++ b/libraries/AP_Mount/AP_Mount_SoloGimbal.cpp @@ -15,7 +15,6 @@ AP_Mount_SoloGimbal::AP_Mount_SoloGimbal(AP_Mount &frontend, AP_Mount_Params &pa void AP_Mount_SoloGimbal::init() { _initialised = true; - set_mode((enum MAV_MOUNT_MODE)_params.default_mode.get()); AP_Mount_Backend::init(); }