Commit Graph

16 Commits

Author SHA1 Message Date
Nick Coghlan d972265df8 Improve an internal ipaddress test, add a comment explaining why treating networks as containers of interfaces rather than addresses would prove confusing 2012-06-17 16:33:00 +10:00
Hynek Schlawack ed36b2e55b #14814: Remove redundant code from ipaddress.IPv6Network
The strict checks and netmask computing don't make sense if constructed with
a ALL_ONES mask based on addresses. Also fix a bug due to mis-indentation of
a return statement in the same code block.
2012-06-08 15:21:21 +02:00
Hynek Schlawack 91c5a34613 #14814: ipaddress: refactor dup code, minor janitoring, bump coverage
- remove duplicate netmask/hostmask code
- make two ifs more pythonic
- remove packed property for networks
- some minor pep8 stuff
- Test coverage is now at 97%, the rest are mostly unreachable safeguards.
2012-06-05 11:55:58 +02:00
Hynek Schlawack 454a74df23 #14814: Remove dead code from ipaddress
_BaseNetwork contained (faulty) methods for creating string representations.
I've fixed them and put them to use by eliminating identical overrides.
2012-06-04 18:14:02 +02:00
Hynek Schlawack bcd304480f #14814: Use correct comparison for IP addresses
ipaddress._BaseV4.is_unspecified() compared IP addresses using "in" which
fails.
2012-06-04 14:19:39 +02:00
Sandro Tosi b4386d36f1 Issue #14814: minor spelling fixes 2012-06-02 17:14:22 +02:00
Hynek Schlawack 35db513187 #14814: Fix errror message creation in ipaddress.collapse_addresses 2012-06-01 20:12:17 +02:00
Hynek Schlawack c4b78a3e15 #14814: Remove 2.x's new-style classes syntax from ipaddress 2012-06-01 11:48:32 +02:00
Hynek Schlawack 7e0229e90d #14814: Remove stale __hex__ method from ipaddress
Obsolete 2.x method.
2012-06-01 00:20:13 +02:00
Nick Coghlan 2c58910d3d Issue #14814: Clean out an obsolete property and method from ipaddress Network objects 2012-05-27 01:03:25 +10:00
Nick Coghlan aff73f91cc Issue #14814: Cleanup ipaddress header comments 2012-05-27 00:57:25 +10:00
Nick Coghlan 51c3067551 Issue #14814: In the spirit of TOOWTDI, ditch the redundant version parameter to the factory functions by using the appropriate direct class references instead 2012-05-27 00:25:58 +10:00
Hynek Schlawack 072b1e1485 #14814: Some PEP8 adjustments and dead code weeding 2012-05-26 12:04:56 +02:00
Sandro Tosi b95c63413d Issue #14814: minor improvements as suggested by Hynek Schlawack 2012-05-23 23:17:22 +02:00
Sandro Tosi 876ecad9f5 Issue #14814: improve docstrings and arguments value handling, as per Terry J. Reedy's comments 2012-05-23 22:26:55 +02:00
Nick Coghlan dc9b2555a8 Issue #14814: addition of the ipaddress module (stage 1 - code and tests) 2012-05-20 21:01:57 +10:00