From f1ae5cf5c7f17e1103735060457fccd5844d21c9 Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Tue, 8 May 2012 09:22:24 -0400 Subject: [PATCH] fix possible refleak (closes #14752) --- Objects/typeobject.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Objects/typeobject.c b/Objects/typeobject.c index 08e5775fa23..3bb0459998d 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -3565,6 +3565,7 @@ add_methods(PyTypeObject *type, PyMethodDef *meth) for (; meth->ml_name != NULL; meth++) { PyObject *descr; + int err; if (PyDict_GetItemString(dict, meth->ml_name) && !(meth->ml_flags & METH_COEXIST)) continue; @@ -3588,9 +3589,10 @@ add_methods(PyTypeObject *type, PyMethodDef *meth) } if (descr == NULL) return -1; - if (PyDict_SetItemString(dict, meth->ml_name, descr) < 0) - return -1; + err = PyDict_SetItemString(dict, meth->ml_name, descr); Py_DECREF(descr); + if (err < 0) + return -1; } return 0; }