From a40675a1a232479bbc2cb9437db265416eeb5b2d Mon Sep 17 00:00:00 2001 From: Richard Oudkerk Date: Sun, 23 Mar 2014 11:54:15 +0000 Subject: [PATCH] Issue #20990: Fix issues found by pyflakes for multiprocessing. --- Lib/multiprocessing/spawn.py | 12 ++++++++++-- Lib/multiprocessing/synchronize.py | 7 ++++--- Misc/NEWS | 2 ++ 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/Lib/multiprocessing/spawn.py b/Lib/multiprocessing/spawn.py index c8297f3134c..8dc48ddd77d 100644 --- a/Lib/multiprocessing/spawn.py +++ b/Lib/multiprocessing/spawn.py @@ -64,7 +64,14 @@ def freeze_support(): Run code for process object if this in not the main process ''' if is_forking(sys.argv): - main() + kwds = {} + for arg in sys.argv[2:]: + name, value = arg.split('=') + if value == 'None': + kwds[name] = None + else: + kwds[name] = int(value) + spawn_main(**kwds) sys.exit() @@ -73,7 +80,8 @@ def get_command_line(**kwds): Returns prefix of command line used for spawning a child process ''' if getattr(sys, 'frozen', False): - return [sys.executable, '--multiprocessing-fork'] + tmp = ' '.join('%s=%r' % item for item in kwds.items()) + return [sys.executable, '--multiprocessing-fork'] + tmp else: prog = 'from multiprocessing.spawn import spawn_main; spawn_main(%s)' prog %= ', '.join('%s=%r' % item for item in kwds.items()) diff --git a/Lib/multiprocessing/synchronize.py b/Lib/multiprocessing/synchronize.py index 0e3f6ec2e94..dea1cbd7f0b 100644 --- a/Lib/multiprocessing/synchronize.py +++ b/Lib/multiprocessing/synchronize.py @@ -49,9 +49,10 @@ class SemLock(object): _rand = tempfile._RandomNameSequence() def __init__(self, kind, value, maxvalue, *, ctx): - ctx = ctx or get_context() - ctx = ctx.get_context() - unlink_now = sys.platform == 'win32' or ctx._name == 'fork' + if ctx is None: + ctx = context._default_context.get_context() + name = ctx.get_start_method() + unlink_now = sys.platform == 'win32' or name == 'fork' for i in range(100): try: sl = self._semlock = _multiprocessing.SemLock( diff --git a/Misc/NEWS b/Misc/NEWS index 6b527ea4406..2f9afb96988 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -21,6 +21,8 @@ Core and Builtins Library ------- +- Issue #20990: Fix issues found by pyflakes for multiprocessing. + - Issue #21015: SSL contexts will now automatically select an elliptic curve for ECDH key exchange on OpenSSL 1.0.2 and later, and otherwise default to "prime256v1".