From a883a3d5fdfefdf198bd34f6d07273063bc1f3b5 Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Mon, 29 Apr 2002 13:54:48 +0000 Subject: [PATCH] See discussion at SF bug 547537. Unicode objects are currently taken as binary data by the write() method. This is not what Unicode users expect, nor what the StringIO.py code does. Until somebody adds a way to specify binary or text mode for cStringIO objects, change the format string to use "t#" instead of "s#", so that it will request the "text buffer" version. This will try the default encoding for Unicode objects. This is *not* a 2.2 bugfix (since it *is* a semantic change). --- Modules/cStringIO.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/cStringIO.c b/Modules/cStringIO.c index 068a8354137..1dbec846516 100644 --- a/Modules/cStringIO.c +++ b/Modules/cStringIO.c @@ -376,7 +376,7 @@ O_write(Oobject *self, PyObject *args) { char *c; int l; - UNLESS (PyArg_ParseTuple(args, "s#:write", &c, &l)) return NULL; + UNLESS (PyArg_ParseTuple(args, "t#:write", &c, &l)) return NULL; if (O_cwrite((PyObject*)self,c,l) < 0) return NULL;