From ade0412613f7628e34d947168cd5f447fa6b8f17 Mon Sep 17 00:00:00 2001 From: Yury Selivanov Date: Thu, 5 Nov 2015 14:29:04 -0500 Subject: [PATCH] asyncio: Optimize asyncio.sleep(0) --- Lib/asyncio/tasks.py | 4 ++++ Lib/test/test_asyncio/test_tasks.py | 24 ++++++++++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/Lib/asyncio/tasks.py b/Lib/asyncio/tasks.py index b887d88934f..77a93e0fe0a 100644 --- a/Lib/asyncio/tasks.py +++ b/Lib/asyncio/tasks.py @@ -488,6 +488,10 @@ def as_completed(fs, *, loop=None, timeout=None): @coroutine def sleep(delay, result=None, *, loop=None): """Coroutine that completes after a given time (in seconds).""" + if delay == 0: + yield + return result + future = futures.Future(loop=loop) h = future._loop.call_later(delay, future._set_result_unless_cancelled, result) diff --git a/Lib/test/test_asyncio/test_tasks.py b/Lib/test/test_asyncio/test_tasks.py index 9772baed1c5..b492cf0153c 100644 --- a/Lib/test/test_asyncio/test_tasks.py +++ b/Lib/test/test_asyncio/test_tasks.py @@ -2188,5 +2188,29 @@ class RunCoroutineThreadsafeTests(test_utils.TestCase): self.assertEqual(context['exception'], exc_context.exception) +class SleepTests(test_utils.TestCase): + def setUp(self): + self.loop = asyncio.new_event_loop() + asyncio.set_event_loop(None) + + def test_sleep_zero(self): + result = 0 + + def inc_result(num): + nonlocal result + result += num + + @asyncio.coroutine + def coro(): + self.loop.call_soon(inc_result, 1) + self.assertEqual(result, 0) + num = yield from asyncio.sleep(0, loop=self.loop, result=10) + self.assertEqual(result, 1) # inc'ed by call_soon + inc_result(num) # num should be 11 + + self.loop.run_until_complete(coro()) + self.assertEqual(result, 11) + + if __name__ == '__main__': unittest.main()