From 2bc801c4ea7b47d4b6db49e0ac0d9e0b3cfef010 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Sun, 18 Dec 2011 19:27:45 +0100 Subject: [PATCH] =?UTF-8?q?Issue=20#7502:=20Fix=20equality=20comparison=20?= =?UTF-8?q?for=20DocTestCase=20instances.=20Patch=20by=20C=C3=A9dric=20Kri?= =?UTF-8?q?er.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Lib/doctest.py | 41 ++++++++++++++++++++++++++++++++++++++++ Lib/test/test_doctest.py | 40 +++++++++++++++++++++++++++++++++++++++ Misc/ACKS | 1 + Misc/NEWS | 3 +++ 4 files changed, 85 insertions(+) diff --git a/Lib/doctest.py b/Lib/doctest.py index f60b06d7c9a..3daf17fa50d 100644 --- a/Lib/doctest.py +++ b/Lib/doctest.py @@ -440,6 +440,21 @@ class Example: self.options = options self.exc_msg = exc_msg + def __eq__(self, other): + if type(self) is not type(other): + return NotImplemented + + return self.source == other.source and \ + self.want == other.want and \ + self.lineno == other.lineno and \ + self.indent == other.indent and \ + self.options == other.options and \ + self.exc_msg == other.exc_msg + + def __ne__(self, other): + return not self == other + + class DocTest: """ A collection of doctest examples that should be run in a single @@ -488,6 +503,19 @@ class DocTest: return ('' % (self.name, self.filename, self.lineno, examples)) + def __eq__(self, other): + if type(self) is not type(other): + return NotImplemented + + return self.examples == other.examples and \ + self.docstring == other.docstring and \ + self.globs == other.globs and \ + self.name == other.name and \ + self.filename == other.filename and \ + self.lineno == other.lineno + + def __ne__(self, other): + return not self == other # This lets us sort tests by name: def __lt__(self, other): @@ -2204,6 +2232,19 @@ class DocTestCase(unittest.TestCase): def id(self): return self._dt_test.name + def __eq__(self, other): + if type(self) is not type(other): + return NotImplemented + + return self._dt_test == other._dt_test and \ + self._dt_optionflags == other._dt_optionflags and \ + self._dt_setUp == other._dt_setUp and \ + self._dt_tearDown == other._dt_tearDown and \ + self._dt_checker == other._dt_checker + + def __ne__(self, other): + return not self == other + def __repr__(self): name = self._dt_test.name.split('.') return "%s (%s)" % (name[-1], '.'.join(name[:-1])) diff --git a/Lib/test/test_doctest.py b/Lib/test/test_doctest.py index 13836bafa06..676d5de6f7a 100644 --- a/Lib/test/test_doctest.py +++ b/Lib/test/test_doctest.py @@ -347,6 +347,46 @@ will raise a ValueError: Traceback (most recent call last): ValueError: line 2 of the docstring for some_test lacks blank after ...: '...print(1)' +Compare `DocTest`: + + >>> docstring = ''' + ... >>> print 12 + ... 12 + ... ''' + >>> test = parser.get_doctest(docstring, globs, 'some_test', + ... 'some_test', 20) + >>> same_test = parser.get_doctest(docstring, globs, 'some_test', + ... 'some_test', 20) + >>> test == same_test + True + >>> test != same_test + False + >>> docstring = ''' + ... >>> print 42 + ... 42 + ... ''' + >>> other_test = parser.get_doctest(docstring, globs, 'other_test', + ... 'other_file', 10) + >>> test == other_test + False + >>> test != other_test + True + +Compare `DocTestCase`: + + >>> DocTestCase = doctest.DocTestCase + >>> test_case = DocTestCase(test) + >>> same_test_case = DocTestCase(same_test) + >>> other_test_case = DocTestCase(other_test) + >>> test_case == same_test_case + True + >>> test_case != same_test_case + False + >>> test == other_test_case + False + >>> test != other_test_case + True + """ def test_DocTestFinder(): r""" diff --git a/Misc/ACKS b/Misc/ACKS index 10f138676d7..86c78abde8c 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -509,6 +509,7 @@ Bob Kras Holger Krekel Michael Kremer Fabian Kreutz +Cédric Krier Hannu Krosing Andrej Krpic Ivan Krstić diff --git a/Misc/NEWS b/Misc/NEWS index 72b33b99f3b..7dbaaff5f6a 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -97,6 +97,9 @@ Core and Builtins Library ------- +- Issue #7502: Fix equality comparison for DocTestCase instances. Patch by + Cédric Krier. + - Issue #8035: urllib: Fix a bug where the client could remain stuck after a redirection or an error.