From 896c317b43260451b3773d905b8fc90027ea50bf Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Fri, 21 Mar 2008 20:46:11 +0000 Subject: [PATCH] Add XXX comments for whoever cleans up getargs.c :) --- Python/getargs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Python/getargs.c b/Python/getargs.c index abe0887bf54..1370e098adc 100644 --- a/Python/getargs.c +++ b/Python/getargs.c @@ -823,6 +823,9 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags, } else return converterr("string", arg, msgbuf, bufsize); + /* XXX(gb): this test is completely wrong -- p is a + * byte string while arg is a Unicode. I *think* it should + * check against the size of uarg... */ if ((Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg)) return converterr("string without null bytes", arg, msgbuf, bufsize); @@ -898,6 +901,7 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags, } format++; } + /* XXX(gb): same comment as for 's' applies here... */ else if (*p != NULL && (Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg)) return converterr(