From 853c0f9d601ca23727e1519d9b2ee82ccb45989f Mon Sep 17 00:00:00 2001 From: R David Murray Date: Wed, 20 Mar 2013 21:54:05 -0400 Subject: [PATCH] #5713: fix timing issue in smtplib tests. --- Lib/test/test_smtplib.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Lib/test/test_smtplib.py b/Lib/test/test_smtplib.py index 92f986b72ee..e5df6c7a609 100644 --- a/Lib/test/test_smtplib.py +++ b/Lib/test/test_smtplib.py @@ -789,6 +789,7 @@ class SMTPSimTests(unittest.TestCase): # Issue 5713: make sure close, not rset, is called if we get a 421 error def test_421_from_mail_cmd(self): smtp = smtplib.SMTP(HOST, self.port, local_hostname='localhost', timeout=15) + smtp.noop() self.serv._SMTPchannel.mail_response = '421 closing connection' with self.assertRaises(smtplib.SMTPSenderRefused): smtp.sendmail('John', 'Sally', 'test message') @@ -797,6 +798,7 @@ class SMTPSimTests(unittest.TestCase): def test_421_from_rcpt_cmd(self): smtp = smtplib.SMTP(HOST, self.port, local_hostname='localhost', timeout=15) + smtp.noop() self.serv._SMTPchannel.rcpt_response = ['250 accepted', '421 closing'] with self.assertRaises(smtplib.SMTPRecipientsRefused) as r: smtp.sendmail('John', ['Sally', 'Frank', 'George'], 'test message') @@ -813,6 +815,7 @@ class SMTPSimTests(unittest.TestCase): super().found_terminator() self.serv.channel_class = MySimSMTPChannel smtp = smtplib.SMTP(HOST, self.port, local_hostname='localhost', timeout=15) + smtp.noop() with self.assertRaises(smtplib.SMTPDataError): smtp.sendmail('John@foo.org', ['Sally@foo.org'], 'test message') self.assertIsNone(smtp.sock)