Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Disallow function calls like foo(None=1). 

Backport from py3k rev. 55708 by Guido.
 (backport from rev. 55802)
This commit is contained in:
Georg Brandl 2007-06-07 13:23:28 +00:00
parent c98da3d811
commit 73c958aced
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/test/test_compile.py
View File

@ -37,6 +37,9 @@ class TestSpecifics(unittest.TestCase):
def test_syntax_error(self):
self.assertRaises(SyntaxError, compile, "1+*3", "filename", "exec")
def test_none_keyword_arg(self):
self.assertRaises(SyntaxError, compile, "f(None=1)", "<string>", "exec")
def test_duplicate_global_local(self):
try:
exec 'def f(a): global a; a = 1'

7
Python/ast.c
View File

@ -1855,13 +1855,18 @@ ast_for_call(struct compiling *c, const node *n, expr_ty func)
* then is very confusing.
*/
if (e->kind == Lambda_kind) {
ast_error(CHILD(ch, 0), "lambda cannot contain assignment");
ast_error(CHILD(ch, 0),
"lambda cannot contain assignment");
return NULL;
} else if (e->kind != Name_kind) {
ast_error(CHILD(ch, 0), "keyword can't be an expression");
return NULL;
}
key = e->v.Name.id;
if (!strcmp(PyString_AS_STRING(key), "None")) {
ast_error(CHILD(ch, 0), "assignment to None");
return NULL;
}
e = ast_for_expr(c, CHILD(ch, 2));
if (!e)
return NULL;