From 67c1a04bbbad20a6a66aa32d35fe41baf2660a51 Mon Sep 17 00:00:00 2001 From: Barry Warsaw Date: Fri, 18 Aug 2000 05:00:03 +0000 Subject: [PATCH] PyFloat_FromString(): Move s_buffer[] up to the top-level function scope. Previously, s_buffer[] was defined inside the PyUnicode_Check() scope, but referred to in the outer scope via assignment to s. This quiets an Insure portability warning. --- Objects/floatobject.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Objects/floatobject.c b/Objects/floatobject.c index 26b39e89212..5650b41302e 100644 --- a/Objects/floatobject.c +++ b/Objects/floatobject.c @@ -133,6 +133,7 @@ PyFloat_FromString(PyObject *v, char **pend) const char *s, *last, *end; double x; char buffer[256]; /* For errors */ + char s_buffer[256]; int len; if (PyString_Check(v)) { @@ -140,8 +141,6 @@ PyFloat_FromString(PyObject *v, char **pend) len = PyString_GET_SIZE(v); } else if (PyUnicode_Check(v)) { - char s_buffer[256]; - if (PyUnicode_GET_SIZE(v) >= sizeof(s_buffer)) { PyErr_SetString(PyExc_ValueError, "float() literal too large to convert");