Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-33274: Compliance with DOM L1: return removed attribute (#7465) 

* bpo-33274: Compliance with DOM L1: return removed attribute

* Update 2018-06-06-22-01-33.bpo-33274.teYqv8.rst
This commit is contained in:
arikrupnik 2018-06-06 23:42:38 -05:00 committed by Fred Drake
parent 7c69c1c0fb
commit 5bfa058e65
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/test/test_minidom.py
View File

@ -325,7 +325,7 @@ class MinidomTest(unittest.TestCase):
node = child.getAttributeNode("spam") node = child.getAttributeNode("spam")
self.assertRaises(xml.dom.NotFoundErr, child.removeAttributeNode, self.assertRaises(xml.dom.NotFoundErr, child.removeAttributeNode,
None) None)
child.removeAttributeNode(node) self.assertIs(node, child.removeAttributeNode(node))
self.confirm(len(child.attributes) == 0 self.confirm(len(child.attributes) == 0
and child.getAttributeNode("spam") is None) and child.getAttributeNode("spam") is None)
dom2 = Document() dom2 = Document()

1
Lib/xml/dom/minidom.py
View File

@ -823,6 +823,7 @@ class Element(Node):
# Restore this since the node is still useful and otherwise # Restore this since the node is still useful and otherwise
# unlinked # unlinked
node.ownerDocument = self.ownerDocument node.ownerDocument = self.ownerDocument
return node
removeAttributeNodeNS = removeAttributeNode removeAttributeNodeNS = removeAttributeNode

3
Misc/NEWS.d/next/Library/2018-06-06-22-01-33.bpo-33274.teYqv8.rst Normal file
View File

@ -0,0 +1,3 @@
W3C DOM Level 1 specifies return value of Element.removeAttributeNode() as
"The Attr node that was removed." xml.dom.minidom now complies with this
requirement.