From 08888650aa03e285a97f84f34c2629ec8a8a8681 Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Thu, 25 May 2023 13:03:55 -0700 Subject: [PATCH] Fix umask test failures under Codespaces (#104913) Also turn on the Python extension for Python code completions and bump the installed versions of wasmtime and the WASI SDK. --- .devcontainer/Dockerfile | 4 ++-- .devcontainer/devcontainer.json | 17 ++++++++++++----- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index efbdcd402cd..590d7834b2b 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -2,11 +2,11 @@ FROM docker.io/library/fedora:37 ENV CC=clang -ENV WASI_SDK_VERSION=19 +ENV WASI_SDK_VERSION=20 ENV WASI_SDK_PATH=/opt/wasi-sdk ENV WASMTIME_HOME=/opt/wasmtime -ENV WASMTIME_VERSION=7.0.0 +ENV WASMTIME_VERSION=9.0.1 ENV WASMTIME_CPU_ARCH=x86_64 RUN dnf -y --nodocs --setopt=install_weak_deps=False install /usr/bin/{blurb,clang,curl,git,ln,tar,xz} 'dnf-command(builddep)' && \ diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 9fbaf7fddd8..0dc303015df 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -9,7 +9,9 @@ "-y", "which", "zsh", - "fish" + "fish", + // For umask fix below. + "/usr/bin/setfacl" ], "updateContentCommand": { // Using the shell for `nproc` usage. @@ -22,6 +24,11 @@ "html" ] }, + "postCreateCommand": { + // https://github.com/orgs/community/discussions/26026 + "umask fix: workspace": ["sudo", "setfacl", "-bnR", "."], + "umask fix: /tmp": ["sudo", "setfacl", "-bnR", "/tmp"] + }, "customizations": { "vscode": { "extensions": [ @@ -31,10 +38,10 @@ "maelvalais.autoconf", // C auto-complete. "ms-vscode.cpptools", - // To view built docs. - "ms-vscode.live-server" - // https://github.com/microsoft/vscode-python/issues/18073 - // "ms-python.python" + // To view HTML build of docs. + "ms-vscode.live-server", + // Python auto-complete. + "ms-python.python" ], "settings": { "C_Cpp.default.compilerPath": "/usr/bin/clang",