From 03f3be50af5bb56e27ffad28a31b21c060630273 Mon Sep 17 00:00:00 2001 From: Neal Norwitz Date: Fri, 14 Apr 2006 05:35:39 +0000 Subject: [PATCH] Update notes to address cyclic garbage and what should happen when a test is fixed. --- Lib/test/leakers/README.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Lib/test/leakers/README.txt b/Lib/test/leakers/README.txt index 69ee35a8845..beeee0e7fa6 100644 --- a/Lib/test/leakers/README.txt +++ b/Lib/test/leakers/README.txt @@ -5,6 +5,15 @@ the interpreter was built in debug mode. If the total ref count doesn't increase, the bug has been fixed and the file should be removed from the repository. +Note: be careful to check for cyclic garbage. Sometimes it may be helpful +to define the leak function like: + +def leak(): + def inner_leak(): + # this is the function that leaks, but also creates cycles + inner_leak() + gc.collect() ; gc.collect() ; gc.collect() + Here's an example interpreter session for test_gestalt which still leaks: >>> from test.leakers.test_gestalt import leak @@ -17,3 +26,7 @@ Here's an example interpreter session for test_gestalt which still leaks: [28940 refs] >>> +Once the leak is fixed, the test case should be moved into an appropriate +test (even if it was originally from the test suite). This ensures the +regression doesn't happen again. And if it does, it should be easier +to track down.