#!/usr/bin/env python3 """ Contains functions used to test the ArduPilot build_options.py structures To extract feature sizes: cat >> /tmp/extra-hwdef.dat < 1: self.progress("Disabling %s disables (%s)" % ( feature.define, ",".join(defines.keys()))) self.test_compile_with_defines(defines) self.assert_feature_not_in_code(defines, feature) def assert_feature_not_in_code(self, defines, feature): # if the feature is truly disabled then extract_features.py # should say so: for target in self.build_targets: path = self.target_to_elf_path(target) extracter = extract_features.ExtractFeatures(path) (compiled_in_feature_defines, not_compiled_in_feature_defines) = extracter.extract() for define in defines: # the following defines are known not to work on some # or all vehicles: feature_define_whitelist = set([ 'AP_RANGEFINDER_ENABLED', # only at vehicle level ATM 'HAL_PERIPH_SUPPORT_LONG_CAN_PRINTF', # no symbol ]) if define in compiled_in_feature_defines: error = f"feature gated by {define} still compiled into ({target}); extract_features.py bug?" if define in feature_define_whitelist: print("warn: " + error) else: raise ValueError(error) def test_enable_feature(self, feature, options): defines = self.get_enable_defines(feature, options) enabled = list(filter(lambda x : bool(defines[x]), defines.keys())) if len(enabled) > 1: self.progress("Enabling %s enables (%s)" % ( feature.define, ",".join(enabled))) self.test_compile_with_defines(defines) self.assert_feature_in_code(defines, feature) def define_is_whitelisted_for_feature_in_code(self, target, define): '''returns true if we can not expect the define to be extracted from the binary''' # the following defines are known not to work on some # or all vehicles: feature_define_whitelist = set([ 'AP_RANGEFINDER_ENABLED', # only at vehicle level ATM 'HAL_PERIPH_SUPPORT_LONG_CAN_PRINTF', # no symbol 'AP_DRONECAN_VOLZ_FEEDBACK_ENABLED', # broken, no subscriber # Baro drivers either come in because you have # external-probing enabled or you have them specified in # your hwdef. If you're not probing and its not in your # hwdef then the code will be elided as unreachable 'AP_BARO_ICM20789_ENABLED', 'AP_BARO_ICP101XX_ENABLED', 'AP_BARO_ICP201XX_ENABLED', 'AP_BARO_BMP085_ENABLED', 'AP_BARO_BMP280_ENABLED', 'AP_BARO_BMP388_ENABLED', 'AP_BARO_BMP581_ENABLED', 'AP_BARO_DPS280_ENABLED', 'AP_BARO_FBM320_ENABLED', 'AP_BARO_KELLERLD_ENABLED', 'AP_BARO_LPS2XH_ENABLED', 'AP_BARO_MS56XX_ENABLED', 'AP_BARO_SPL06_ENABLED', 'AP_CAMERA_SEND_FOV_STATUS_ENABLED', # elided unless AP_CAMERA_SEND_FOV_STATUS_ENABLED 'AP_COMPASS_LSM9DS1_ENABLED', # must be in hwdef, not probed 'AP_COMPASS_MAG3110_ENABLED', # must be in hwdef, not probed 'AP_COMPASS_MMC5XX3_ENABLED', # must be in hwdef, not probed 'AP_MAVLINK_AUTOPILOT_VERSION_REQUEST_ENABLED', # completely elided 'AP_MAVLINK_MSG_RELAY_STATUS_ENABLED', # no symbol available 'AP_MAVLINK_MAV_CMD_REQUEST_AUTOPILOT_CAPABILITIES_ENABLED', # no symbol available 'HAL_MSP_SENSORS_ENABLED', # no symbol available 'AP_OSD_LINK_STATS_EXTENSIONS_ENABLED', # FIXME: need a new define/feature 'HAL_OSD_SIDEBAR_ENABLE', # FIXME: need a new define/feature 'HAL_PLUSCODE_ENABLE', # FIXME: need a new define/feature 'AP_SERIALMANAGER_REGISTER_ENABLED', # completely elided without a caller 'AP_OPTICALFLOW_ONBOARD_ENABLED', # only instantiated on Linux 'HAL_WITH_FRSKY_TELEM_BIDIRECTIONAL', # entirely elided if no user 'AP_PLANE_BLACKBOX_LOGGING', # entirely elided if no user 'AP_COMPASS_AK8963_ENABLED', # probed on a board-by-board basis, not on CubeOrange for example 'AP_COMPASS_LSM303D_ENABLED', # probed on a board-by-board basis, not on CubeOrange for example ]) if target.lower() != "copter": feature_define_whitelist.add('MODE_ZIGZAG_ENABLED') feature_define_whitelist.add('MODE_SYSTEMID_ENABLED') feature_define_whitelist.add('MODE_SPORT_ENABLED') feature_define_whitelist.add('MODE_FOLLOW_ENABLED') feature_define_whitelist.add('MODE_TURTLE_ENABLED') feature_define_whitelist.add('MODE_GUIDED_NOGPS_ENABLED') feature_define_whitelist.add('MODE_FLOWHOLD_ENABLED') feature_define_whitelist.add('MODE_FLIP_ENABLED') feature_define_whitelist.add('MODE_BRAKE_ENABLED') feature_define_whitelist.add('AP_TEMPCALIBRATION_ENABLED') feature_define_whitelist.add('AC_PAYLOAD_PLACE_ENABLED') feature_define_whitelist.add('AP_AVOIDANCE_ENABLED') feature_define_whitelist.add('AP_WINCH_ENABLED') feature_define_whitelist.add('AP_WINCH_DAIWA_ENABLED') feature_define_whitelist.add('AP_WINCH_PWM_ENABLED') feature_define_whitelist.add(r'AP_MOTORS_FRAME_.*_ENABLED') feature_define_whitelist.add('AP_COPTER_ADVANCED_FAILSAFE_ENABLED') if target.lower() != "plane": # only on Plane: feature_define_whitelist.add('AP_ICENGINE_ENABLED') feature_define_whitelist.add('AP_PLANE_OFFBOARD_GUIDED_SLEW_ENABLED') feature_define_whitelist.add('AP_MAVLINK_MAV_CMD_SET_HAGL_ENABLED') feature_define_whitelist.add('AP_ADVANCEDFAILSAFE_ENABLED') feature_define_whitelist.add('AP_TUNING_ENABLED') feature_define_whitelist.add('HAL_LANDING_DEEPSTALL_ENABLED') feature_define_whitelist.add('HAL_SOARING_ENABLED') feature_define_whitelist.add('AP_PLANE_BLACKBOX_LOGGING') feature_define_whitelist.add('QAUTOTUNE_ENABLED') feature_define_whitelist.add('AP_PLANE_OFFBOARD_GUIDED_SLEW_ENABLED') feature_define_whitelist.add('HAL_QUADPLANE_ENABLED') feature_define_whitelist.add('AP_BATTERY_WATT_MAX_ENABLED') if target.lower() not in ["plane", "copter"]: feature_define_whitelist.add('HAL_ADSB_ENABLED') feature_define_whitelist.add('AP_LANDINGGEAR_ENABLED') # only Plane and Copter instantiate Parachute feature_define_whitelist.add('HAL_PARACHUTE_ENABLED') # only Plane and Copter have AP_Motors: if target.lower() not in ["rover", "copter"]: # only Plane and Copter instantiate Beacon feature_define_whitelist.add('AP_BEACON_ENABLED') if target.lower() != "rover": # only on Rover: feature_define_whitelist.add('HAL_TORQEEDO_ENABLED') feature_define_whitelist.add('AP_ROVER_ADVANCED_FAILSAFE_ENABLED') if target.lower() != "sub": # only on Sub: feature_define_whitelist.add('AP_BARO_KELLERLD_ENABLED') if target.lower() not in frozenset(["rover", "sub"]): # only Rover and Sub get nmea airspeed feature_define_whitelist.add('AP_AIRSPEED_NMEA_ENABLED') if target.lower() not in frozenset(["copter", "rover"]): feature_define_whitelist.add('HAL_SPRAYER_ENABLED') feature_define_whitelist.add('HAL_PROXIMITY_ENABLED') feature_define_whitelist.add('AP_PROXIMITY_.*_ENABLED') feature_define_whitelist.add('AP_OAPATHPLANNER_ENABLED') if target.lower() in ["blimp", "antennatracker"]: # no airspeed on blimp/tracker feature_define_whitelist.add(r'AP_AIRSPEED_.*_ENABLED') feature_define_whitelist.add(r'HAL_MOUNT_ENABLED') feature_define_whitelist.add(r'AP_MOUNT_.*_ENABLED') feature_define_whitelist.add(r'HAL_MOUNT_.*_ENABLED') feature_define_whitelist.add(r'HAL_SOLO_GIMBAL_ENABLED') feature_define_whitelist.add(r'AP_OPTICALFLOW_ENABLED') feature_define_whitelist.add(r'AP_OPTICALFLOW_.*_ENABLED') feature_define_whitelist.add(r'HAL_MSP_OPTICALFLOW_ENABLED') # missing calls to fence.check(): feature_define_whitelist.add(r'AP_FENCE_ENABLED') # RPM not instantiated on Blimp or Rover: feature_define_whitelist.add(r'AP_RPM_ENABLED') feature_define_whitelist.add(r'AP_RPM_.*_ENABLED') # rangefinder init is not called: feature_define_whitelist.add(r'HAL_MSP_RANGEFINDER_ENABLED') # these guys don't instantiate anything which uses sd-card storage: feature_define_whitelist.add(r'AP_SDCARD_STORAGE_ENABLED') feature_define_whitelist.add(r'AP_RANGEFINDER_ENABLED') feature_define_whitelist.add(r'AP_RANGEFINDER_.*_ENABLED') if target.lower() in ["blimp", "antennatracker", "sub"]: # no OSD on Sub/blimp/tracker feature_define_whitelist.add(r'OSD_ENABLED') feature_define_whitelist.add(r'OSD_PARAM_ENABLED') # AP_OSD is not instantiated, , so no MSP backend: feature_define_whitelist.add(r'HAL_WITH_MSP_DISPLAYPORT') # camera instantiated in specific vehicles: feature_define_whitelist.add(r'AP_CAMERA_ENABLED') feature_define_whitelist.add(r'AP_CAMERA_.*_ENABLED') # button update is not called in these vehicles feature_define_whitelist.add(r'HAL_BUTTON_ENABLED') # precland not instantiated on these vehicles feature_define_whitelist.add(r'AC_PRECLAND_ENABLED') feature_define_whitelist.add(r'AC_PRECLAND_.*_ENABLED') # RSSI is not initialised - probably should be for some feature_define_whitelist.add(r'AP_RSSI_ENABLED') if target.lower() in ["antennatracker", "sub"]: # missing the init call to the relay library: feature_define_whitelist.add(r'AP_RELAY_ENABLED') feature_define_whitelist.add(r'AP_RC_CHANNEL_AUX_FUNCTION_STRINGS_ENABLED') for some_re in feature_define_whitelist: if re.match(some_re, define): return True def assert_feature_in_code(self, defines, feature): # if the feature is truly disabled then extract_features.py # should say so: for target in self.build_targets: path = self.target_to_elf_path(target) extracter = extract_features.ExtractFeatures(path) (compiled_in_feature_defines, not_compiled_in_feature_defines) = extracter.extract() for define in defines: if not defines[define]: continue if define in compiled_in_feature_defines: continue error = f"feature gated by {define} not compiled into ({target}); extract_features.py bug?" if self.define_is_whitelisted_for_feature_in_code(target, define): print("warn: " + error) continue raise ValueError(error) def board(self): '''returns board to build for''' return self._board def test_compile_with_defines(self, defines): extra_hwdef_filepath = "/tmp/extra.hwdef" self.write_defines_to_file(defines, extra_hwdef_filepath) if self.extra_hwdef is not None: content = open(self.extra_hwdef, "r").read() with open(extra_hwdef_filepath, "a") as f: f.write(content) util.waf_configure( self.board(), extra_hwdef=extra_hwdef_filepath, ) for t in self.build_targets: try: util.run_cmd([util.relwaf(), t]) except Exception: print("Failed to build (%s) with things disabled" % (t,)) raise def target_to_path(self, target, extension=None): '''given a build target (e.g. copter), return expected path to .bin file for that target''' target_to_binpath = { "copter": "arducopter", "plane": "arduplane", "rover": "ardurover", "antennatracker": "antennatracker", "sub": "ardusub", "blimp": "blimp", } filename = target_to_binpath[target] if extension is not None: filename += "." + extension return os.path.join("build", self.board(), "bin", filename) def target_to_bin_path(self, target): '''given a build target (e.g. copter), return expected path to .bin file for that target''' return self.target_to_path(target, 'bin') def target_to_elf_path(self, target): '''given a build target (e.g. copter), return expected path to .elf file for that target''' return self.target_to_path(target) def find_build_sizes(self): '''returns a hash with size of all build targets''' ret = {} for target in self.build_targets: path = self.target_to_bin_path(target) ret[target] = os.path.getsize(path) return ret def csv_for_results(self, results): '''return a string with csv for results''' features = sorted(results.keys()) all_vehicles = set() for feature in features: all_vehicles.update(list(results[feature].keys())) sorted_all_vehicles = sorted(list(all_vehicles)) ret = "" ret += ",".join(["Feature"] + sorted_all_vehicles) + "\n" for feature in features: line = [feature] feature_results = results[feature] for vehicle in sorted_all_vehicles: bytes_delta = "" if vehicle in feature_results: result = feature_results[vehicle] bytes_delta = result.bytes_delta line.append(str(bytes_delta)) ret += ",".join(line) + "\n" return ret def disable_in_turn_check_sizes(self, feature, sizes_nothing_disabled): if not self.do_step_disable_none: self.progress("disable-none skipped, size comparison not available") return current_sizes = self.find_build_sizes() for (build, new_size) in current_sizes.items(): old_size = sizes_nothing_disabled[build] self.progress("Disabling %s(%s) on %s saves %u bytes" % (feature.label, feature.define, build, old_size - new_size)) if feature.define not in self.results: self.results[feature.define] = {} self.results[feature.define][build] = TestBuildOptionsResult(feature.define, build, old_size - new_size) with open("/tmp/some.csv", "w") as f: f.write(self.csv_for_results(self.results)) def run_disable_in_turn(self): progress_file = pathlib.Path("/tmp/run-disable-in-turn-progress") resume_number = self.resume_number_from_progress_Path(progress_file) options = self.get_build_options_from_ardupilot_tree() count = 1 for feature in sorted(options, key=lambda x : x.define): if resume_number is not None: if count < resume_number: count += 1 continue if self.match_glob is not None: if not fnmatch.fnmatch(feature.define, self.match_glob): continue with open(progress_file, "w") as f: f.write(f"{count}/{len(options)} {feature.define}\n") # if feature.define < "WINCH_ENABLED": # count += 1 # continue if feature.define in self.must_have_defines_for_board(self._board): self.progress("Feature %s(%s) (%u/%u) is a MUST-HAVE" % (feature.label, feature.define, count, len(options))) count += 1 continue self.progress("Disabling feature %s(%s) (%u/%u)" % (feature.label, feature.define, count, len(options))) self.test_disable_feature(feature, options) count += 1 self.disable_in_turn_check_sizes(feature, self.sizes_nothing_disabled) def enable_in_turn_check_sizes(self, feature, sizes_everything_disabled): if not self.do_step_disable_all: self.progress("disable-none skipped, size comparison not available") return current_sizes = self.find_build_sizes() for (build, new_size) in current_sizes.items(): old_size = sizes_everything_disabled[build] self.progress("Enabling %s(%s) on %s costs %u bytes" % (feature.label, feature.define, build, old_size - new_size)) if feature.define not in self.enable_in_turn_results: self.enable_in_turn_results[feature.define] = {} self.enable_in_turn_results[feature.define][build] = TestBuildOptionsResult(feature.define, build, old_size - new_size) # noqa with open("/tmp/enable-in-turn.csv", "w") as f: f.write(self.csv_for_results(self.enable_in_turn_results)) def resume_number_from_progress_Path(self, progress_file): if not self.resume: return None try: content = progress_file.read_text().rstrip() m = re.match(r"(\d+)/\d+ \w+", content) if m is None: raise ValueError(f"{progress_file} not matched") return int(m.group(1)) except FileNotFoundError: pass return None def run_enable_in_turn(self): progress_file = pathlib.Path("/tmp/run-enable-in-turn-progress") resume_number = self.resume_number_from_progress_Path(progress_file) options = self.get_build_options_from_ardupilot_tree() count = 1 for feature in options: if resume_number is not None: if count < resume_number: count += 1 continue if self.match_glob is not None: if not fnmatch.fnmatch(feature.define, self.match_glob): continue self.progress("Enabling feature %s(%s) (%u/%u)" % (feature.label, feature.define, count, len(options))) with open(progress_file, "w") as f: f.write(f"{count}/{len(options)} {feature.define}\n") self.test_enable_feature(feature, options) count += 1 self.enable_in_turn_check_sizes(feature, self.sizes_everything_disabled) def get_option_by_label(self, label, options): for x in options: if x.label == label: return x raise ValueError("No such option (%s)" % label) def get_disable_all_defines(self): '''returns a hash of defines which turns all features off''' options = self.get_build_options_from_ardupilot_tree() defines = {} for feature in options: if self.match_glob is not None: if not fnmatch.fnmatch(feature.define, self.match_glob): continue defines[feature.define] = 0 for define in self.must_have_defines_for_board(self._board): defines[define] = 1 return defines def run_disable_all(self): defines = self.get_disable_all_defines() self.test_compile_with_defines(defines) self.sizes_everything_disabled = self.find_build_sizes() def run_disable_none(self): self.test_compile_with_defines({}) self.sizes_nothing_disabled = self.find_build_sizes() def run_with_defaults(self): options = self.get_build_options_from_ardupilot_tree() defines = {} for feature in options: defines[feature.define] = feature.default self.test_compile_with_defines(defines) def check_deps_consistency(self): # self.progress("Checking deps consistency") options = self.get_build_options_from_ardupilot_tree() for feature in options: self.get_disable_defines(feature, options) def check_duplicate_labels(self): '''check that we do not have multiple features with same labels''' options = self.get_build_options_from_ardupilot_tree() seen_labels = {} for feature in options: if seen_labels.get(feature.label, None) is not None: raise ValueError("Duplicate entries found for label '%s'" % feature.label) seen_labels[feature.label] = True def do_emit_disable_all_defines(self): defines = tbo.get_disable_all_defines() for f in self.must_have_defines(): defines[f] = 1 tbo.write_defines_to_Path(defines, pathlib.Path("/dev/stdout")) sys.exit(0) def run(self): self.check_deps_consistency() self.check_duplicate_labels() if self.emit_disable_all_defines: self.do_emit_disable_all_defines() sys.exit(0) if self.do_step_run_with_defaults: self.progress("Running run-with-defaults step") self.run_with_defaults() if self.do_step_disable_all: self.progress("Running disable-all step") self.run_disable_all() if self.do_step_disable_none: self.progress("Running disable-none step") self.run_disable_none() if self.do_step_disable_in_turn: self.progress("Running disable-in-turn step") self.run_disable_in_turn() if self.do_step_enable_in_turn: self.progress("Running enable-in-turn step") self.run_enable_in_turn() if __name__ == '__main__': parser = optparse.OptionParser() parser.add_option("--define-match-glob", type='string', default=None, help='feature define must match this glob to be tested') parser.add_option("--no-run-with-defaults", action='store_true', help='Do not run the run-with-defaults step') parser.add_option("--no-disable-all", action='store_true', help='Do not run the disable-all step') parser.add_option("--no-disable-none", action='store_true', help='Do not run the disable-none step') parser.add_option("--no-disable-in-turn", action='store_true', help='Do not run the disable-in-turn step') parser.add_option("--no-enable-in-turn", action='store_true', help='Do not run the enable-in-turn step') parser.add_option("--build-targets", type='choice', choices=TestBuildOptions.all_targets(), action='append', help='vehicle targets to build') parser.add_option("--extra-hwdef", type='string', default=None, help="file containing extra hwdef information") parser.add_option("--board", type='string', default="CubeOrange", help='board to build for') parser.add_option("--emit-disable-all-defines", action='store_true', help='emit defines used for disabling all features then exit') parser.add_option("--resume", action='store_true', help='resume from previous progress file') opts, args = parser.parse_args() tbo = TestBuildOptions( match_glob=opts.define_match_glob, do_step_disable_all=not opts.no_disable_all, do_step_disable_none=not opts.no_disable_none, do_step_disable_defaults=not opts.no_run_with_defaults, do_step_disable_in_turn=not opts.no_disable_in_turn, do_step_enable_in_turn=not opts.no_enable_in_turn, build_targets=opts.build_targets, board=opts.board, extra_hwdef=opts.extra_hwdef, emit_disable_all_defines=opts.emit_disable_all_defines, resume=opts.resume, ) tbo.run()