From 7f3f135dc56aef3c632c92d3d47a9657542431d2 Mon Sep 17 00:00:00 2001 From: Andy Piper Date: Tue, 20 Oct 2020 22:41:52 +0100 Subject: [PATCH] AP_RCProtocol: add debug for further CRSF messages add better frame debug info to CRSF --- libraries/AP_RCProtocol/AP_RCProtocol_CRSF.cpp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libraries/AP_RCProtocol/AP_RCProtocol_CRSF.cpp b/libraries/AP_RCProtocol/AP_RCProtocol_CRSF.cpp index 737f077dd4..12106fee08 100644 --- a/libraries/AP_RCProtocol/AP_RCProtocol_CRSF.cpp +++ b/libraries/AP_RCProtocol/AP_RCProtocol_CRSF.cpp @@ -80,11 +80,14 @@ static const char* get_frame_type(uint8_t byte) return "ATTITUDE"; case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_FLIGHT_MODE: return "FLIGHT_MODE"; + case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_PARAM_DEVICE_INFO: + return "DEVICE_INFO"; + case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_PARAMETER_READ: + return "PARAM_READ"; + case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_PARAMETER_SETTINGS_ENTRY: + return "SETTINGS_ENTRY"; case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_LINK_STATISTICS: case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_RC_CHANNELS_PACKED: - case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_PARAM_DEVICE_INFO: - case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_PARAMETER_SETTINGS_ENTRY: - case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_PARAMETER_READ: case AP_RCProtocol_CRSF::CRSF_FRAMETYPE_PARAMETER_WRITE: return "UNKNOWN"; } @@ -259,7 +262,12 @@ void AP_RCProtocol_CRSF::write_frame(Frame* frame) #ifdef CRSF_DEBUG hal.console->printf("CRSF: writing %s:", get_frame_type(frame->type)); for (uint8_t i = 0; i < frame->length + 2; i++) { - hal.console->printf(" 0x%x", ((uint8_t*)frame)[i]); + uint8_t val = ((uint8_t*)frame)[i]; + if (val >= 32 && val <= 126) { + hal.console->printf(" 0x%x '%c'", val, (char)val); + } else { + hal.console->printf(" 0x%x", val); + } } hal.console->printf("\n"); #endif